Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot housekeeping dies on missing snapshot - why? #60

Open
alyarb opened this issue Jun 3, 2020 · 2 comments
Open

snapshot housekeeping dies on missing snapshot - why? #60

alyarb opened this issue Jun 3, 2020 · 2 comments

Comments

@alyarb
Copy link

alyarb commented Jun 3, 2020

If the barc snapshot is missing from the RBD, it aborts. who would want that functionality?

consider the current code:

#Snapshot Housekeeping..                
                #find last snapshot in ceph
                latest_snap=$(rbd snap ls "$image_spec" | \
                              awk '{print $2}' | \
                              grep "$opt_label" | sort -r | head -n 1)

                #not exist snapshot on rbd
                if [ -z "$latest_snap" ]; then
                    log error "VM $vm_id - Ceph last snapshot '$image_spec' not found!";                    
                    call_hook_script "export-diff-abort" "-" "-"                 
                    rc=30                         
                    break;
                fi

We want to backup this VM/disk... the snapshot is merely a means to an end. If it's missing, forget about it, create a new one, and do a new run with renew=0....?

@alyarb alyarb changed the title snapshot housekeeping dies on missing snapshot - why snapshot housekeeping dies on missing snapshot - why? Jun 3, 2020
@lephisto
Copy link
Contributor

THis is to protect you from a broken incremental snapshot chain in your backups.

I have plans to auto-fix this, eg make a full backup if the Snap is missing. Currently the sanity of the Backupchain has to be taken care of manually.

@alyarb
Copy link
Author

alyarb commented Jun 16, 2020

Thank you, looking forward to an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants