Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-package shinyMlr #119

Closed
florianfendt opened this issue Apr 1, 2017 · 7 comments
Closed

R-package shinyMlr #119

florianfendt opened this issue Apr 1, 2017 · 7 comments
Labels

Comments

@florianfendt
Copy link
Contributor

I hacked together a little R-package to make life for people who wish to install our app locally a little bit easier. The package is in the branch "package" and the workflow to install and start shinyMlr is as follows:

devtools::install_github("mlr-org/shinyMlr", ref = "package")
library(shinyMlr)
# download a copy of the app to your machine
downloadShinyMlr()
# launch app
runShinyMlr()

@everyone especially @berndbischl
opinions?
Plus: Does it make sense to upload this on CRAN or would that be obsolete anyway once we host the
app on a server?

@jakob-r
Copy link
Contributor

jakob-r commented Apr 3, 2017

I think we would never want to run this on our own server exclusively. If this is supposed to run fast and reliable for many people it's going to be expensive. Who want's to pay for that? A try out server with a max user limit could work though. But then a dedicated package would be the go-to.

I think transforming this into a package is the way to go and the effect of beeing on cran should not be underestimated. However the downloadShinyMlr() solution does not look so well. All necessary files should be part of the package.

@jakob-r
Copy link
Contributor

jakob-r commented Apr 3, 2017

@jakob-r jakob-r self-assigned this Apr 3, 2017
@jakob-r
Copy link
Contributor

jakob-r commented Apr 3, 2017

My suggest is here #121

@jakob-r jakob-r removed their assignment Apr 3, 2017
@florianfendt
Copy link
Contributor Author

@jakob-r
great. Thx for your input and your PR. Putting the package into master like this seems indeed more straightforward. 👍

@jakob-r
Copy link
Contributor

jakob-r commented Apr 3, 2017

of course you could also restructure everything and live without linking the files - but i don't know if that makes development easier as it makes most parts of the development more nested. Also I did not want to do this in a PR 😉

@florianfendt
Copy link
Contributor Author

I think we would never want to run this on our own server exclusively. If this is supposed to run fast and reliable for many people it's going to be expensive. Who want's to pay for that? A try out server with a max user limit could work though. But then a dedicated package would be the go-to.

Yes, we need a good server solution soon. @berndbischl already mentioned he has contacts where we could possibly host the app. We have a separate Issue for that #11, where we started talking about that.

@florianfendt
Copy link
Contributor Author

Closing here. #121 is merged. Package is now in master ./package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants