Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image attachment corruption #3231

Open
georgweiss opened this issue Jan 14, 2025 · 0 comments
Open

Image attachment corruption #3231

georgweiss opened this issue Jan 14, 2025 · 0 comments

Comments

@georgweiss
Copy link
Collaborator

georgweiss commented Jan 14, 2025

Discovered in a log entry: an image transferred from iPhone in HEIC format was converted to jpeg in the Mac OS Preview app. That conversion apparently is very Mac OS centric. See hex dumps in attached files.

The converted file can be opened in the Preview app, but not in a browser. In the Phoebus Olog client a call like
ImageIO.read(attachment.getFile());
will in this case return null and not throw an exception.

Will address this in the log editor such that the UI will indicate the null case (e.g. "Cannot load image"), but it is still up to the user to inspect image files in the attachments preview.

Corrupt jpeg:
Screenshot 2025-01-14 at 08 27 12

Non-currupt (different image data):
Screenshot 2025-01-14 at 08 41 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant