Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize the legend area when traces are hidden #2725

Merged

Conversation

rjwills28
Copy link
Contributor

We came across an issue in the databrowser where the area taken up to display the traces legend does not shrink when traces are hidden. This is particular noticeable if the plot contains many traces of which most are hidden.
It turns out that in the code the legend area is determined using all the traces even if they are not being displayed. This PR fixes this issue by only considering the visible traces.

@rjwills28
Copy link
Contributor Author

Build fails due to an unrelated issue - see fix in PR #2726. PR 2726 needs to be merged and pulled into this branch first before re-running the CI job for this PR.

kasemir pushed a commit to ControlSystemStudio/phoebus that referenced this pull request Feb 27, 2024
@kasemir
Copy link
Contributor

kasemir commented Feb 27, 2024

Turns out the JFX version had the 'continue' part but still counted all traces, so thanks for this update

@shroffk
Copy link
Member

shroffk commented Mar 13, 2024

@rjwills28 can you update this branch... with #2726 merged we should be able to get the CI working again here

The legend area is determined using the legends of all the traces
even if they are not being displayed. This fix addresses that by
only considering the visible traces.
@rjwills28 rjwills28 force-pushed the css610_legend_area branch from 351b9f1 to 2346488 Compare March 13, 2024 14:29
@shroffk shroffk merged commit 6b1fce6 into ControlSystemStudio:master Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants