Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage #361

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Add code coverage #361

merged 3 commits into from
Sep 26, 2023

Conversation

mga-chka
Copy link
Collaborator

Description

Increasing the test coverage and fixing a nil panic (in the tests) following this issue #353
Please check the type of change your PR introduces:

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no api changes)
  • [] Build related changes
  • [] Documentation content changes
  • [] Other (please describe):

Checklist

  • [] Linter passes correctly
  • [] Add tests which fail without the change (if possible)
  • [] All tests passing
  • [] Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@render
Copy link

render bot commented Sep 26, 2023

Your Render PR Server URL is https://chproxy-pr-361.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ck99mfegtj9c738fhn7g.

sigua-cs
sigua-cs approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@sigua-cs sigua-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mga-chka mga-chka merged commit a868dc5 into master Sep 26, 2023
2 checks passed
@mga-chka mga-chka deleted the add_code_coverage branch September 26, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigua-cs sigua-cs sigua-cs approved these changes

@gontarzpawel gontarzpawel Awaiting requested review from gontarzpawel

@Blokje5 Blokje5 Awaiting requested review from Blokje5

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mga-chka @sigua-cs