Implemented expectedGasLimit from spec #8909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a more complete test suite on the FN to show boundaries. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
jtraglia
reviewed
Dec 11, 2024
...onlayer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/BuilderBidValidatorImpl.java
Show resolved
Hide resolved
rolfyone
commented
Dec 11, 2024
Comment on lines
+229
to
+240
| Arguments.of(36_000_000L, 36_000_000L, 36_000_000L), | ||
| Arguments.of(1024_000L, 1024_000L, 1024_000L), | ||
| // down inside bounds | ||
| Arguments.of(1024_000L, 1023_500L, 1023_500L), | ||
| // down outside bounds - results in a partial move | ||
| Arguments.of(36_000_000L, 35_000_000L, 35_964_845L), | ||
| Arguments.of(1024_000L, 1020_000L, 1023_001L), | ||
| // increase outside bounds - results in a partial move | ||
| Arguments.of(1024_000L, 1025_000L, 1024_999L), | ||
| Arguments.of(30_000_000L, 36_000_000L, 30_029_295L), | ||
| // increase inside bounds | ||
| Arguments.of(1024_000L, 1024_500L, 1024_500L)); |
There was a problem hiding this comment.
@jtraglia so the args are parent, target, expected output...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a more complete test suite on the FN to show boundaries.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog