Skip to content

Commit

Permalink
Merge branch 'master' into simplify-BlobSidecarAvailabilityChecker
Browse files Browse the repository at this point in the history
  • Loading branch information
tbenr authored Dec 13, 2024
2 parents e13c529 + 6b07218 commit 66accfa
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
### Additions and Improvements

### Bug Fixes
- Fixed an issue with the `/eth/v1/config/spec` API not returning all previously included configuration parameters.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public GetSpec(final DataProvider dataProvider) {
@Override
public void handleRequest(final RestApiRequest request) throws JsonProcessingException {
try {
final SpecConfigData responseContext = new SpecConfigData(configProvider.getGenesisSpec());
final SpecConfigData responseContext = new SpecConfigData(configProvider.getSpecConfig());
request.respondOk(responseContext.getConfigMap());
} catch (JsonProcessingException e) {
String message =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

class GetSpecTest extends AbstractMigratedBeaconHandlerTest {
private final ConfigProvider configProvider = new ConfigProvider(spec);
private final SpecConfigData response = new SpecConfigData(configProvider.getGenesisSpecConfig());
private final SpecConfigData response = new SpecConfigData(configProvider.getSpecConfig());

@BeforeEach
void setUp() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,13 @@ public ConfigProvider(final Spec spec) {
}

public Map<String, String> getConfig() {
final SpecConfigData configuration = new SpecConfigData(spec.getGenesisSpecConfig());
final SpecConfigData configuration =
new SpecConfigData(spec.getSpecConfigAndParent().specConfig());
return configuration.getConfigMap();
}

public SpecConfig getGenesisSpec() {
return spec.atEpoch(UInt64.ZERO).getConfig();
public SpecConfig getSpecConfig() {
return spec.getSpecConfigAndParent().specConfig();
}

public static String formatValue(final Object v) {
Expand Down

0 comments on commit 66accfa

Please sign in to comment.