You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to have the following variations on all of the tests from #1435. The failing bytecode is that which was specified in the original "simple exceptions tests" issue, but the byte code in question lives in different places. It may be the byte code of:
the toAddress of the transaction (as is currently the case for most tests, except for staticException related ones for instance and maybe others)
the initCode of a deployment transaction
a contract which was CALL/CALLCODE/DELEGATECALL/STATICCALL'ed from the root context, followed by it deciding to either
WILL_REVERT
WONT_REVERT
an attempted deployment with CREATE/CREATE2 from the root context, followed by it deciding to either
This issue is a follow-up issue of #1435.
Extending the tests
We need to have the following variations on all of the tests from #1435. The failing bytecode is that which was specified in the original "simple exceptions tests" issue, but the byte code in question lives in different places. It may be the byte code of:
toAddress
of the transaction (as is currently the case for most tests, except forstaticException
related ones for instance and maybe others)initCode
of a deployment transactionCALL
/CALLCODE
/DELEGATECALL
/STATICCALL
'ed from the root context, followed by it deciding to eitherWILL_REVERT
WONT_REVERT
CREATE
/CREATE2
from the root context, followed by it deciding to eitherWILL_REVERT
WONT_REVERT
How many tests are required
We should have both
The text was updated successfully, but these errors were encountered: