Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the "simple exception tests" #1638

Open
8 tasks
OlivierBBB opened this issue Dec 11, 2024 · 0 comments
Open
8 tasks

Extending the "simple exception tests" #1638

OlivierBBB opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels

Comments

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Dec 11, 2024

This issue is a follow-up issue of #1435.

Extending the tests

We need to have the following variations on all of the tests from #1435. The failing bytecode is that which was specified in the original "simple exceptions tests" issue, but the byte code in question lives in different places. It may be the byte code of:

  • the toAddress of the transaction (as is currently the case for most tests, except for staticException related ones for instance and maybe others)
  • the initCode of a deployment transaction
  • a contract which was CALL/CALLCODE/DELEGATECALL/STATICCALL'ed from the root context, followed by it deciding to either
    • WILL_REVERT
    • WONT_REVERT
  • an attempted deployment with CREATE/CREATE2 from the root context, followed by it deciding to either
    • WILL_REVERT
    • WONT_REVERT

How many tests are required

We should have both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants