From c603a5028a645b547236dbfd8de84d8806320446 Mon Sep 17 00:00:00 2001 From: "fuder.eth" <139509124+vtjl10@users.noreply.github.com> Date: Sat, 14 Dec 2024 14:01:25 +0100 Subject: [PATCH 1/3] Update get-started.md Signed-off-by: fuder.eth <139509124+vtjl10@users.noreply.github.com> --- docs/get-started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/get-started.md b/docs/get-started.md index 04b7aa620..91aaa5e06 100644 --- a/docs/get-started.md +++ b/docs/get-started.md @@ -29,7 +29,7 @@ pnpm run test:e2e:local To stop that stack run: ``` -make clean-enviroment +make clean-environment ``` While running the end2end tests, you should observe files being generated in `tmp/local/` directory. From 0153b86437e8ee52b6de46f867370cfb3363f5ea Mon Sep 17 00:00:00 2001 From: "fuder.eth" <139509124+vtjl10@users.noreply.github.com> Date: Sat, 14 Dec 2024 14:02:03 +0100 Subject: [PATCH 2/3] Update Timelock.ts Signed-off-by: fuder.eth <139509124+vtjl10@users.noreply.github.com> --- contracts/test/messageService/lib/Timelock.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/test/messageService/lib/Timelock.ts b/contracts/test/messageService/lib/Timelock.ts index 52f459daf..05754803b 100644 --- a/contracts/test/messageService/lib/Timelock.ts +++ b/contracts/test/messageService/lib/Timelock.ts @@ -46,7 +46,7 @@ describe("Timelock", () => { expect(await contract.hasRole(EXECUTOR_ROLE, executor.address)).to.be.true; }); - it("Should set the minDelay state variable with the value passed in the contructor params", async () => { + it("Should set the minDelay state variable with the value passed in the constructor params", async () => { expect(await contract.getMinDelay()).to.equal(10); }); }); From cc585c3ac1da2f7a773249f906abe90cde3e5090 Mon Sep 17 00:00:00 2001 From: "fuder.eth" <139509124+vtjl10@users.noreply.github.com> Date: Sat, 14 Dec 2024 14:02:40 +0100 Subject: [PATCH 3/3] Update contract-style-guide.md Signed-off-by: fuder.eth <139509124+vtjl10@users.noreply.github.com> --- contracts/docs/contract-style-guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/docs/contract-style-guide.md b/contracts/docs/contract-style-guide.md index ff19dcfed..7d73c76d1 100644 --- a/contracts/docs/contract-style-guide.md +++ b/contracts/docs/contract-style-guide.md @@ -38,7 +38,7 @@ Contracts and interfaces will use the [NatSpec](https://docs.soliditylang.org/en ## General - Avoid magic numbers by using constants - Name variables so that their intent is easy to understand -- In assembly memory mappings use hexidecimal values for memory offsets - e.g `mstore(add(mPtr, 0x20), _varName)` +- In assembly memory mappings use hexadecimal values for memory offsets - e.g `mstore(add(mPtr, 0x20), _varName)` ## Linting Be sure to run `pnpm run lint:fix` in the contracts folder or `pnpm run -F contracts lint:fix` from the repository root. @@ -107,4 +107,4 @@ contract SampleContract { // 6. Modifiers // 7. Functions (Public, external, internal and then private) } -``` \ No newline at end of file +```