From b1236c725b4e0ce8d72c7d6b38a976b8cd7ac017 Mon Sep 17 00:00:00 2001 From: Eric Date: Wed, 11 Dec 2024 18:16:21 +0300 Subject: [PATCH] New-branch-mono --- contracts/docs/contract-style-guide.md | 4 ++-- contracts/test/messageService/lib/Timelock.ts | 2 +- docs/get-started.md | 2 +- prover/maths/field/gen.go | 2 +- prover/symbolic/variable.go | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/contracts/docs/contract-style-guide.md b/contracts/docs/contract-style-guide.md index ff19dcfed..7d73c76d1 100644 --- a/contracts/docs/contract-style-guide.md +++ b/contracts/docs/contract-style-guide.md @@ -38,7 +38,7 @@ Contracts and interfaces will use the [NatSpec](https://docs.soliditylang.org/en ## General - Avoid magic numbers by using constants - Name variables so that their intent is easy to understand -- In assembly memory mappings use hexidecimal values for memory offsets - e.g `mstore(add(mPtr, 0x20), _varName)` +- In assembly memory mappings use hexadecimal values for memory offsets - e.g `mstore(add(mPtr, 0x20), _varName)` ## Linting Be sure to run `pnpm run lint:fix` in the contracts folder or `pnpm run -F contracts lint:fix` from the repository root. @@ -107,4 +107,4 @@ contract SampleContract { // 6. Modifiers // 7. Functions (Public, external, internal and then private) } -``` \ No newline at end of file +``` diff --git a/contracts/test/messageService/lib/Timelock.ts b/contracts/test/messageService/lib/Timelock.ts index 52f459daf..05754803b 100644 --- a/contracts/test/messageService/lib/Timelock.ts +++ b/contracts/test/messageService/lib/Timelock.ts @@ -46,7 +46,7 @@ describe("Timelock", () => { expect(await contract.hasRole(EXECUTOR_ROLE, executor.address)).to.be.true; }); - it("Should set the minDelay state variable with the value passed in the contructor params", async () => { + it("Should set the minDelay state variable with the value passed in the constructor params", async () => { expect(await contract.getMinDelay()).to.equal(10); }); }); diff --git a/docs/get-started.md b/docs/get-started.md index 04b7aa620..91aaa5e06 100644 --- a/docs/get-started.md +++ b/docs/get-started.md @@ -29,7 +29,7 @@ pnpm run test:e2e:local To stop that stack run: ``` -make clean-enviroment +make clean-environment ``` While running the end2end tests, you should observe files being generated in `tmp/local/` directory. diff --git a/prover/maths/field/gen.go b/prover/maths/field/gen.go index 63a30ac4a..bc14a9cf2 100644 --- a/prover/maths/field/gen.go +++ b/prover/maths/field/gen.go @@ -7,7 +7,7 @@ import ( ) // ParBatchInvert is as a parallel implementation of [BatchInvert]. The caller -// can supply the target number of cores to use to perform the paralellization. +// can supply the target number of cores to use to perform the parallelization. // If `numCPU=0` is provided, the function defaults to using all the available // cores exposed by the OS. func ParBatchInvert(a []Element, numCPU int) []Element { diff --git a/prover/symbolic/variable.go b/prover/symbolic/variable.go index 60b382472..b968fee02 100644 --- a/prover/symbolic/variable.go +++ b/prover/symbolic/variable.go @@ -16,7 +16,7 @@ import ( // used to instantiate a [Variable] with them. type Metadata interface { /* - Strings allows adressing a map by variable 2 instances for which + Strings allows addressing a map by variable 2 instances for which String() returns the same result are treated as equal. */ String() string