Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator Integration tests - fix account generation to handle and retry on "Replacement transaction underpriced" error #413

Open
jpnovais opened this issue Dec 10, 2024 · 2 comments
Labels
bug Something isn't working Coordinator good first issue Good for newcomers

Comments

@jpnovais
Copy link
Collaborator

jpnovais commented Dec 10, 2024

Impact

environment: CI Pipeline

Describe the bug

Steps to Reproduce

Coordinator integration tests generate new accounts for every run for test isolation, this account generation relies on whale accounts from the genesis file to fund the new account.

When tests run in parallel, sometimes the same whale account is used to fund the new account and we get Response.Error(code=-32000, message=Replacement transaction underpriced) in net.consensys.zkevm.ethereum.WhaleBasedAccountManager.generateAccounts(AccountManager.kt:149)

The WhaleBasedAccountManager shall be adapted to handle this error and retry funding the account with new nonce

The bugs is not deterministically reproducible. It happens randomly sometimes

Failure example: https://github.com/Consensys/linea-monorepo/actions/runs/12245260143/job/34158810717

@jpnovais jpnovais added bug Something isn't working good first issue Good for newcomers Coordinator labels Dec 10, 2024
@sureshkrishnan-v
Copy link

Hi, I’d like to work on this issue as a first-time contributor—could you confirm if it’s available and share any guidelines?

@jpnovais
Copy link
Collaborator Author

Hi, yes issues is still open to be addressed. As mentioned in the ticket description the error shall be handled here

I would recommend to create a function fundAccount(fromAccountTxManager, toAccountAddress, amount) with this code and retries when it gets a "Replacement transaction underpriced" error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Coordinator good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants