From 482b31ecb746168a81bf981dff1783f41a2d51ff Mon Sep 17 00:00:00 2001 From: Victorien Gauch <85494462+VGau@users.noreply.github.com> Date: Mon, 14 Oct 2024 13:36:28 +0200 Subject: [PATCH] Fix: remove ci docker login condition (#182) * fix: remove ci docker login condition * fix: remove publish condition for bridge UI --- .github/workflows/bridge-ui-publish.yml | 1 - .github/workflows/coordinator-build-and-publish.yml | 1 - .github/workflows/reuse-run-e2e-tests.yml | 1 - .github/workflows/reuse-tag-without-untested-suffix.yml | 1 - .github/workflows/traces-api-facade-build-and-publish.yml | 1 - 5 files changed, 5 deletions(-) diff --git a/.github/workflows/bridge-ui-publish.yml b/.github/workflows/bridge-ui-publish.yml index 28bad2dd1..7b63d6e58 100644 --- a/.github/workflows/bridge-ui-publish.yml +++ b/.github/workflows/bridge-ui-publish.yml @@ -15,7 +15,6 @@ on: jobs: publish: runs-on: [self-hosted, ubuntu-20.04, X64, small] - if: github.event_name != 'pull_request' || (github.event_name == 'pull_request' && github.event.pull_request.draft == false) steps: - name: Checkout uses: actions/checkout@v3 diff --git a/.github/workflows/coordinator-build-and-publish.yml b/.github/workflows/coordinator-build-and-publish.yml index 2673cc2a8..022bddd1d 100644 --- a/.github/workflows/coordinator-build-and-publish.yml +++ b/.github/workflows/coordinator-build-and-publish.yml @@ -55,7 +55,6 @@ jobs: run: | ./gradlew coordinator:app:distZip --no-daemon - name: Login to Docker Hub - if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }} diff --git a/.github/workflows/reuse-run-e2e-tests.yml b/.github/workflows/reuse-run-e2e-tests.yml index ac3cd9c9f..c646e9053 100644 --- a/.github/workflows/reuse-run-e2e-tests.yml +++ b/.github/workflows/reuse-run-e2e-tests.yml @@ -88,7 +88,6 @@ jobs: with: pnpm-install-options: '--frozen-lockfile --prefer-offline' - name: Login to Docker Hub - if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }} diff --git a/.github/workflows/reuse-tag-without-untested-suffix.yml b/.github/workflows/reuse-tag-without-untested-suffix.yml index e0ee72a12..2eb3f943f 100644 --- a/.github/workflows/reuse-tag-without-untested-suffix.yml +++ b/.github/workflows/reuse-tag-without-untested-suffix.yml @@ -29,7 +29,6 @@ jobs: image_name: ${{ fromJSON(inputs.image_names) }} steps: - name: Login to Docker Hub - if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }} diff --git a/.github/workflows/traces-api-facade-build-and-publish.yml b/.github/workflows/traces-api-facade-build-and-publish.yml index 536730a37..f9079b454 100644 --- a/.github/workflows/traces-api-facade-build-and-publish.yml +++ b/.github/workflows/traces-api-facade-build-and-publish.yml @@ -58,7 +58,6 @@ jobs: ./gradlew traces-api-facade:app:shadowJar echo ${{ github.workspace }} - name: Login to Docker Hub - if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }}