-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: compute the fingerprint of a Plonk verification key for recursive verification #1062
Draft
weijiguo
wants to merge
32
commits into
Consensys:master
Choose a base branch
from
lightec-xyz:feat/vkey_fp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revised G2.addUnified function based on the Brier and Joye algorithm
fixed G2.sgn0 function and associated unit tests for BLS12-381
This PR depends on #1040 |
Converted to draft. Just came to awareness that MiMc might output different data under different underlying fields. Reviewing impacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added a new feature to compute the fingerprint (MiMc hash) of a Plonk verification key. The fingerprint could be used to identify a unique verification key or circuit during recursive verification.
Fixes # (issue)
None
Type of change
How has this been tested?
std/recursion/plonk/verifier_test.go
to ensure all curves are supported;std/recursion/plonk/vkey_fp_test.go
to ensure the correctness of the added functionality.How has this been benchmarked?
We adopted the snark-friendly hash MiMc to minimize the constraints count. However no benchmark suites were added.
Checklist:
golangci-lint
does not output errors locally