Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table component docs overflow container #420

Open
as-dr opened this issue Nov 13, 2019 · 1 comment
Open

Table component docs overflow container #420

as-dr opened this issue Nov 13, 2019 · 1 comment

Comments

@as-dr
Copy link

as-dr commented Nov 13, 2019

Describe the bug
Per this issue in the rimble-storefront repo, the Table example in the docs and one in the Do's & Dont's overflows its container at smaller viewports.

It was decided that it was out of scope for the rimble-storefront repo and should be brought over to here.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://rimble.consensys.design/components/rimble-ui/Table
  2. Reduce your browser window consistently to see the bug.

Expected behavior
The Table should be set to overflow-x: scroll in order to scroll horizontally when in danger of overflowing its container.
Padding should also be made responsive, with smaller amounts of padding on all table headings and cells at smaller viewports to avoid vertical text.

Screenshots
https://user-images.githubusercontent.com/797290/68433312-72604500-0173-11ea-86d6-56106783bb36.png

https://user-images.githubusercontent.com/797290/68433365-8e63e680-0173-11ea-9ced-17895fc66275.png

Rimble UI Version

  • 0.7.1 (latest)

Desktop (please complete the following information):

  • OS: MacOSX 10.13.13
  • Browser: Chrome
  • Version 78
@gesquinca
Copy link
Contributor

Thanks for submitting @as-dr. Sounds like this is related to #406 in our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants