Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore specific files completely from optimization #338

Open
MCMDEV opened this issue Nov 12, 2024 · 1 comment
Open

Add option to ignore specific files completely from optimization #338

MCMDEV opened this issue Nov 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MCMDEV
Copy link

MCMDEV commented Nov 12, 2024

Related problem or need

I'd like to have some files that are part of the resourcepack not be optimized/processed but still be added.

Proposed solution

A boolean per-file option

Alternative solutions

Not supporting this

Additional context

I'd like this because I found out that NegativeSpaceFont is incompatible with PackSquash. There is a PR at NegativeSpaceFont to address this (AmberWat/NegativeSpaceFont#11). Nevertheless, I think having the option to skip out on processing could help mitigate similar issues.

@MCMDEV MCMDEV added the enhancement New feature or request label Nov 12, 2024
@AlexTMjugador
Copy link
Member

AlexTMjugador commented Nov 13, 2024

Frankly, I'm reluctant to add new options solely as workarounds for issues in specific packs. Even when they highlight improvable behavior or missing features in PackSquash, I find that the proper solution to that tends to be either improving such behavior or implementing such missing features, not skipping optimization altogether. For AmberWat's negative space font pack, it's better to heed the lint from PackSquash and fix the problem at the source by using interoperable number ranges, as I did in the PR you referenced, where I explained my technical reasoning for that opinion in more detail.

That being said, another user presented a compelling reason for having this feature that goes beyond working around pack issues or limitations in PackSquash, so I'm open to considering it. Still, as a PSA to everyone, please try to avoid using it simply to quietly work around individual pack issues... Imagine the collective hours of time wasted by humanity if everyone added extra options to their own particular PackSquash options file rather than even trying to propose fixing issues at the source for everyone to enjoy, no matter their particular software stack 😅

Thanks a lot for the feedback though, even though I don't agree with the proposed way to solve it I think it's a valuable experience to share and keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants