Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColType: Disallow Copy Contructor #222

Open
ax3l opened this issue Jan 15, 2016 · 1 comment
Open

ColType: Disallow Copy Contructor #222

ax3l opened this issue Jan 15, 2016 · 1 comment
Labels
feature
Milestone
Future

Comments

@ax3l
Copy link
Member

ax3l commented Jan 15, 2016

We should move the copy contructor of CollectionTypes into the private section to disallow by syntax to copy CollectionTypes.

This is due to the fact that most times this results in a corrupted CollectionType causing hard to find bugs.

Example: ColTypeString with fixed length.
@ax3l ax3l added the feature label Jan 15, 2016
@ax3l ax3l added this to the Version 1.4/1.3.x milestone Jan 15, 2016
@ax3l ax3l mentioned this issue Jan 15, 2016
Merged
@ax3l ax3l modified the milestones: Future, Version 1.4 Apr 12, 2016
@ax3l
Copy link
Member Author

ax3l commented Apr 12, 2016

Actually hiding the copy constructor is not so easy since we need colType's as return types in readMeta...

Maybe we should test the copy constructors and implement where they break (vlen/fixed len strings?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@ax3l