-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python PEP8 max line length #65
Comments
|
120 for both limits seems reasonable |
in my experience it doesn't make the code less readable with short lines (there is always a natural point to wrap), but rather better git-diff-able. Comments on the other hand are not nice to write with 60 characters or so. Probably there is a reason why the official proposal suggests it the other way around^^ |
I'm fine even with infinitely long lines, too (my editor can wrap lines if I need it). |
Which is why we picked 120 LOCs for C++, since then you can fit a 3-window diff nicely on a 1440p monitor. @SimeonEhrig and me verified that :) |
That's correct, but I also recognized that 120 LOC is to much for 2 windows side by side on my FHD Displays (mainly on the laptop). 100 LOC would be fine. But I get new WQHD displays 🤔 |
The PEP8 formatting standard that we are enforcing for our python code limits the code lines to max 79 characters, doc-strings and comments are restricted to 72. Together with the indentation and alignment rules in PEP8 this makes the code hard to format and read. For our C++ code, we decided on the 120 characters limit. I suggest we relax the rules for python too. Even the PEP8 says:
Please, comment your opinion on this. I will suggest we vote first if we increase the numbers at all. If you vote to increase one of the limits, please, include a suggestion for a new limit in your comment.
Vote:
The text was updated successfully, but these errors were encountered: