Clean deletion of analytic_tag_id setting parameter and pre-commit cleanings #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoeBerdoz
changed the title
|
Sorry, I also applied pre-commit with another PR. Can you please rebase and squash your commits (one single commit is enough I think). |
NoeBerdoz
force-pushed
the
14-clean-delete-and-precommit
branch
from
645e0da to
daae4db
Compare
|
@ecino I squashed my commits, and merged the missing corrections for the pre-commit, PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete dead files that weren't deleted and are related to this PR #234
Make the repository compliant with pre-commit