Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonsDownloader should allow to download the full-size image #11

Open
JeanFred opened this issue Feb 15, 2015 · 4 comments
Open

CommonsDownloader should allow to download the full-size image #11

JeanFred opened this issue Feb 15, 2015 · 4 comments

Comments

@JeanFred
Copy link
Member

Requested by Coyau: wants CommonsDownloader to download the full-size file.

@JeanFred
Copy link
Member Author

On the back end this is not really hard − we already fetch the fullsize when requesting too big a size (since #2)
The UX aspect is what worries me − how to select this? Another argument --full-size``on the command line, exclusive with the--width` flag? But what about the file list option?

@maflcko
Copy link

maflcko commented May 13, 2015

What about assuming the user wants the full size if no size is specified?

@JeanFred
Copy link
Member Author

@MarcoFalke Thanks for chiming in! That’s a good question − CommonsDownloader started its life as a thumbnail grabber so this was the original assumption which we can certainly revisit :)

The issue I have with this is that Wikimedia Commons files can be quite big (and some are properly huge) − not sure it is a nice experience to fire CommonsDownloader and end up downloading by default megabytes and megabytes. What do you think?

@maflcko
Copy link

maflcko commented May 14, 2015

It really depends on where or by whom your application is used...

But if you want to change the current behavior as little as possible, what about using --width=-1 to request the full size. (Same behavior as the actual mediawiki API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants