First bugs/confusions on app:

[HazardJ]

Putting these all as a single entry for now.

Bugs:

1:
The old value is saved, not the new:
http://www.commonaccord.org/index.php?action=source&file=/G/SeriesSeed-Cooley-CmA/Demo/Acme_Note_ClosingBinder.md
(If you modify the value 2 times in the xEdit interface, then it saves the first modification. )

2:
Some edit popup boxes close when you shift focus to the text box. Cannot edit them. For instance: the Seed.1.Price.Cash.$ ("$200,000"). On the other hand, PromissoryNote.Convert.EquityEvent.ThresholdProceeds.$ ("$1,00,000") works fine.

3:
Let's change the triggering CSS class from "definedterm" to "param", or ADD "param" to "definedterm" as the triggering class. Defined terms are mostly static, so not the things we usually want to change. We will have to add "param" class since we don't currently use that, but they convey the idea better. Ideally, all values would be editable, but my quick test shows that that requires some reworking.

4:
When saving in a file that already has many k/v, I noticed that some were thrown away. On /G/SeriesSeed-Cooley-CmA/Demo/Acme_Equity_ClosingBinder.md, most of the k/vs that begin with key name "/..." were thrown away. I presume this is because you parse the k/vs and are ignoring them. Better would be to simply add the new k/vs to the top of the old file, as is.

Minor:
5: In the doc selection box (under "Source ... Edit ...") selecting another doc fails on my local install. It appears to be a problem that the selection assumes that the instance is in the root of the web server. I have multiple instances, which are, for instance /Org/ and /Source/.

So, when changing in a doc in /Org/, I get:

http://localhost:8888/index.php?action=xEdit&file=G/SeriesSeed-Cooley-CmA/Demo/Acme_Equity_ClosingBinder.md
when I should get:
http://localhost:8888/Org/index.php?action=xEdit&file=G/SeriesSeed-Cooley-CmA/Demo/Acme_Equity_ClosingBinder.md

[HazardJ]

Thanks to Quyhn, the bug 1 is now fixed. A value whose CSS class is "param" will appear in xEdit view with an underline. Right-clicking will pop up an edit box. You edit and save the new value.

[QuynhND]

Hi James, Do you need me to update anything? "params" or other class can be easy set up by add them into Green Text part on xEdit js.

On Thu, Aug 3, 2017 at 2:47 PM HazardJ ***@***.***> wrote: Thanks to Quyhn, the bug 1 is now fixed. A value whose CSS class is "param" will appear in xEdit view with an underline. Right-clicking will pop up an edit box. You edit and save the new value. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGyEdGmib4hIt0snXDhU9hrQ-DXFgQtXks5sUXr5gaJpZM4OY7Ua> .

-- *Thanks & Best Regards!Nguyễn Đăng QuỳnhMobile: (+84) 9045 17186* *E-mails*: *[email protected] <[email protected]>*