Rename settings (consistency)

[jbostoen]

Not sure if I should finish this (probably just needs testing, perhaps remove the explicit config saving instruction).

• removes a redundant line with a typo
• renames the settings to only use underscores (+ handling of existing settings in the configuration file: rewrite. Any native method to delete the old settings?)
• also, some settings were not in the module's config file. While this is not necessary, it makes it clearer to users what the possible settings are. Furthermore; it seems like some of the settings were slightly different between the demo configuration and the default-if-not-specified settings in the code.

The upgrade check could also be based on version number of the extension instead.
Actually for now it does NOT work, it seems configuration is based on what is specified "by default".
I was looking into BeforeWritingConfig, which doesn't support previous and current version. (perhaps this could be added?)
But for some reason, it also doesn't include the existing configuration yet?

[Hipska]

If You are still working on it, please mark it as a draft. (Not in the title)

[jbostoen]

@Hipska I don't think that option is available to me ( "Any user with write access to the repository can convert a pull request to a draft pull request. ")

[Hipska]

Yes you can, in the top right:

[piRGoif]

I agree, as said in #4 I'm not sure this is worst the effort... Actually migrating existing config would be quite a challenge !
I'll ask the team and let you know !

[piRGoif]

As a reference the module config param documentation : https://www.itophub.io/wiki/page?id=extensions%3Aticket-from-email#other_configuration_parameters

[piRGoif]

The wiki page was updated to include module parameter naming convention : Configuration parameter naming

[piRGoif]

We prefer to reject your proposition, as there are more risks than benefits : even if this PR includes the migration code, the benefit is low and as this is part of one of the most popular extension since a long time, any bug would have enormous consequences.

Many thanks for your efforts anyway !