-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
N°2181 - Sometimes duplicate ticket from mail-to-ticket - retention_p…
…eriod become period in hour
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the original fix I did in my fork: I made it a longer time. Think of situations where O365 gives IMAP errors for longer periods of time. Sure they will fix it asap, but one hour as default value might not be that much.
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, @piRGoif are you aware of this breaking change?
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hipska Actually it's still an improvement.
In the original situation, the Mail to Ticket process would still not see the email if the IMAP connection returns errors (which occasionally happened with our O365 environment).
This is more a grace period.
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a breaking change of default values and even if users did specify a specific value, the meaning of it changes. So a migration would need to be done at least.
#4 is also an enhancement, and even there I needed to create a new additional config option to enable the enhancement.
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, never mind. Wasn't aware this config option wasn't in a released version yet. So there is no impact for existing users. Ignore my comments 😅
0976f75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this commit is a fix after testing. In testing, we saw that this period in days is too long, so I changed it to hours.