Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added HPLC Reader (as tar archive) #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StarmanMartin
Copy link
Collaborator

reades Data (no Metadata) from hplc file set. set has to be send as tar archive
X15291.D.tar.gz
X15294.D.tar.gz

close #101

@StarmanMartin StarmanMartin linked an issue May 27, 2024 that may be closed by this pull request
@herrdivad
Copy link
Collaborator

Do you please have a test server?
https://converter.martin-starman.com/admin/ ist not working:
grafik

@StarmanMartin
Copy link
Collaborator Author

Can be tested here

@herrdivad
Copy link
Collaborator

The profile can be downloaded here:
3c2426f0-46d2-415d-a752-b7f48eb0503c(2).json

@PiTrem PiTrem changed the title Added HPLC Reader (as tar archive) feat: Added HPLC Reader (as tar archive) Aug 20, 2024
Copy link
Member

@PiTrem PiTrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could one clean the commit history as most of the visible changes are unrelated?

str2bool~=1.1
parser-binary @ git+https://github.com/ComPlat/BinaryParser@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this install the binary artifact from the repo or does this trigger the building from the source ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What dependencies are needed at runtime ? Does the Readme needs an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New HPLC reader
3 participants