-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generic template from StateTransitionGraph
#25
Labels
🔨 Maintenance
Maintenance and upkeep improvements
Comments
So a few problems:
So I'll put this one back into the icebox. It would be better to get rid of this template altogether, but for that the interface will have to be changed (for instance in #20, see also description of ComPWA/expertsystem#314). |
See also #49 |
redeboer
changed the title
Remove generic template from StateTransitionGraph
Remove generic template from Apr 11, 2022
StateTransitionGraph
Closed by #156 |
redeboer
pushed a commit
to redeboer/ComPWA-qrules
that referenced
this issue
Apr 30, 2022
- Major rework/refactoring of generators and data module - Fixed ComPWA#25: added multi-threading support using parallelstl and tbb. Currently only data generation is multi-threaded. parallelstl and tbb are currently submodules of ComPWA. - Fixed bug in AmpWignerD tree evaluation
redeboer
added a commit
to redeboer/ComPWA-qrules
that referenced
this issue
Apr 30, 2022
* refactor: remove particle_list.xml attributes * refactor!: remove XML attributes internally * fix: input filename for write to XML * refactor: extract load_default_particle_list * ci: do not check docstrings in tests * test: add I/O test for particle_list Closes ComPWA#25, closes ComPWA#26, and closes ComPWA#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that the nested
dict
s have been moved out (#297), it would be nice to remove the edge type template of theStateTransitionGraph
:https://github.com/ComPWA/expertsystem/blob/778541d8b64a4a66259b5421e578cd28f562b744/expertsystem/topology.py#L301-L304
Internally, the
expertsystem
(almost) only usesParticleWithSpin
as edge type. In addition, the fact that the node properties are not templated is counter-intuitive.The text was updated successfully, but these errors were encountered: