Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic template from StateTransitionGraph #25

Closed
redeboer opened this issue Oct 9, 2020 · 3 comments
Closed

Remove generic template from StateTransitionGraph #25

redeboer opened this issue Oct 9, 2020 · 3 comments
Assignees
Labels
🔨 Maintenance Maintenance and upkeep improvements

Comments

@redeboer
Copy link
Member

redeboer commented Oct 9, 2020

Now that the nested dicts have been moved out (#297), it would be nice to remove the edge type template of the StateTransitionGraph:
https://github.com/ComPWA/expertsystem/blob/778541d8b64a4a66259b5421e578cd28f562b744/expertsystem/topology.py#L301-L304

Internally, the expertsystem (almost) only uses ParticleWithSpin as edge type. In addition, the fact that the node properties are not templated is counter-intuitive.

@redeboer redeboer self-assigned this Oct 9, 2020
@redeboer
Copy link
Member Author

So a few problems:

So I'll put this one back into the icebox. It would be better to get rid of this template altogether, but for that the interface will have to be changed (for instance in #20, see also description of ComPWA/expertsystem#314).

@redeboer redeboer removed their assignment Nov 13, 2020
@redeboer redeboer transferred this issue from ComPWA/expertsystem Apr 6, 2021
@redeboer
Copy link
Member Author

See also #49

@redeboer redeboer added the 🔨 Maintenance Maintenance and upkeep improvements label Apr 16, 2021
@redeboer redeboer changed the title Remove generic template from StateTransitionGraph Remove generic template from StateTransitionGraph Apr 11, 2022
@redeboer
Copy link
Member Author

Closed by #156

redeboer pushed a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
- Major rework/refactoring of generators and data module
- Fixed ComPWA#25: added multi-threading support using parallelstl and tbb.
  Currently only data generation is multi-threaded. parallelstl and tbb
  are currently submodules of ComPWA.
- Fixed bug in AmpWignerD tree evaluation
redeboer added a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
* refactor: remove particle_list.xml attributes
* refactor!: remove XML attributes internally
* fix: input filename for write to XML
* refactor: extract load_default_particle_list
* ci: do not check docstrings in tests
* test: add I/O test for particle_list

Closes ComPWA#25, closes ComPWA#26, and closes ComPWA#31
@redeboer redeboer self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

No branches or pull requests

1 participant