Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform treatment of forces on "single-particle" vs. normal atom groups #52

Closed
jhenin opened this issue Apr 27, 2016 · 2 comments
Closed
Assignees

Comments

@jhenin
Copy link
Member

jhenin commented Apr 27, 2016

To properly handle fit gradients for all CVCs in an efficient way, we need to know whether atom groups are involved as their COG/COM, or if the cvc depends on individual coordinates in a more complicated way.

A more general approach is to store a vector of weights, providing for all linear combinations of coordinates (or a weight matrix for vector cvcs).

In those cases, we need to store per-group gradients, instead of per-atom.

@jhenin
Copy link
Member Author

jhenin commented Jun 8, 2016

Side issue to this: treat dummy atoms in a unified way with regular atoms.

@giacomofiorin giacomofiorin self-assigned this Jun 9, 2016
@giacomofiorin
Copy link
Member

This is an easy fix after completing #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants