Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aleksandra's collection #12

Open
AMitiukova opened this issue Jun 7, 2022 · 4 comments
Open

Aleksandra's collection #12

AMitiukova opened this issue Jun 7, 2022 · 4 comments

Comments

@AMitiukova
Copy link

link: https://amitiukova.github.io/MenuCollectionBuilder/

But the pictures are not displayed :(

@dcnb
Copy link
Contributor

dcnb commented Jun 7, 2022

Hi Aleksandra!

There are a couple issues you should attend to.

Your metadata file should not have any spaces in it. Right now you have it listed as "menu collectionbuilder-metadata" in your _config.yml file. Why don't you use the file in your _data folder called "menucollectionbuilder-metadata" and list that as your metadata piece.

I will send you a pull request with some changes to get things working here in a bit. Don't worry!

@dcnb
Copy link
Contributor

dcnb commented Jun 7, 2022

Ok, I sent you a pull request. Read what I put in there and merge the PR into your repository and you should have a clean start. I also moved your metadata to a new sheet (linked in the pull request) that you should use going forward.

AMitiukova/MenuCollectionBuilder#1

@AMitiukova
Copy link
Author

AMitiukova commented Jun 8, 2022 via email

@dcnb
Copy link
Contributor

dcnb commented Jun 8, 2022

Sorry for not seeing this until now, Aleksandra!

The problem with your images is that the extensions have varying capital letters in them and the metadata lists the extension as being lowercase. For example:

the first item (objectid is coll001) has "898.jpg" as its filename. However, in your objects folder, that file appears as: "898.JpG".

I think you'll need to delete those items from your repository, then reupload them. It's a really sticky problem so you'll need to delete them from your folder, make a commit that your doing so, push that commit, then rename the files on your local computer so that the extensions are lowercase, then upload them again.

If you were to merge my pull request into your repository: AMitiukova/MenuCollectionBuilder#1

that should clear up the issue. Here are some instructions on how to do that: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request#merging-a-pull-request

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants