fixed: remove sort query element on other sorting menu items

ColdTrick · Sep 3, 2024 · d35464d · d35464d
1 parent da87035
commit d35464d
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/classes/ColdTrick/GroupTools/Menus/FilterSortItems.php b/classes/ColdTrick/GroupTools/Menus/FilterSortItems.php
@@ -27,6 +27,15 @@ public static function registerPopularSorting(\Elgg\Event $event): ?MenuItems {
 		/* @var $result MenuItems */
 		$result = $event->getValue();
 
+		/* @var $menu_item \ElggMenuItem */
+		foreach ($result as $menu_item) {
+			if ($menu_item->getParentName() !== 'sort:parent') {
+				continue;
+			}
+
+			$menu_item->setHref(elgg_http_remove_url_query_element($menu_item->getHref(), 'sort'));
+		}
+
 		// add sorting based on relationship time_created
 		$result[] = \ElggMenuItem::factory([
 			'name' => 'popular',