Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifikation om invitationer: Vis ikke hvis man deltager i aktivitet #1122

Conversation

mhewel
Copy link
Contributor

@mhewel mhewel commented Oct 27, 2024

Filtrer så deltagere ikke vises (dvs hvis man har tilmeldt sig efter modtaget invitation).

Filtrer så deltagere ikke vises (dvs hvis man har tilmeldt sig efter modtaget invitation).
Copy link

what-the-diff bot commented Oct 27, 2024

PR Summary

  • Updating the EntryPage
    In the EntryPage.py file, we've removed outdated and inefficient code and opted to utilize a streamlined function, get_unaccepted_invitations_for_family, to aid in fetching unaccepted invitations for the user's family.

  • Revamping FamilyDetails
    Just as in EntryPage, we updated FamilyDetails.py with the same function get_unaccepted_invitations_for_family. This ensures both parts of the application are utilizing the most up-to-date and efficient methods in retrieving information.

  • Introducing UnacceptedInvitations.py
    We've introduced a new file, UnacceptedInvitations.py, in which we define the new get_unaccepted_invitations_for_family function. This modular function simplifies the process of fetching unaccepted activity invitations for a given family by implementing a strategic subquery. As a result of this addition, the application now runs smoother and more consistently.

Copy link
Contributor

@rasmusselsmark rasmusselsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet og valideret lokalt, ser korrekt ud

@rasmusselsmark rasmusselsmark merged commit 7e6802f into master Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Notifikationer går ikke væk når man tilmelder barn til aktiviteten
2 participants