Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neve + Easy Digital Downloads: Custom Layout on Download Archive applies incorrectly for Tags & Taxonomy #4286

Closed
shadowsight-ss1 opened this issue Aug 10, 2024 · 1 comment · Fixed by #4287 or #4280
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@shadowsight-ss1
Copy link

Description

With Neve + Easy Digital Downloads, a Neve Custom Layout using the hook "Before Download Archive" gets applied incorrectly when the Download Archive is filtered to a Taxonomy or Tag.

Expected Behavior:
The "Before Download Archive" Custom Layout Hook should apply before the download archive, consistent with how/where it applies when viewing the download archive without a tag/taxonomy filter.

Actual Behavior:
When the download archive is filtered to tag or taxonomy, the "Before Download Archive" Custom Layout Hook applies within the grid container, messing up the page layout as compared to the appearance of the unfiltered download archive.

Step-by-step reproduction instructions

(I cannot remember if reproducing this requires Neve Pro)

  1. Install Neve + EDD
  2. Create enough Downloads with Tags and Categories to fill multiple rows on the Download Archive
  3. Create a Neve Custom Layout for the Hook "Before Download Archive". My Example uses a full-width Cover, a paragraph, and the EDD Download Terms widget
  4. View your downloads archive
  5. View your downloads archive filtered to a tag
  6. View your downloads archive filtered to a Category (aka term aka taxonomy)

Screenshots, screen recording, code snippet or Help Scout ticket

Download Archive (Unfiltered)

download_archive

Download Archive (Tag Filtered)

archive_tag

Download Archive (Taxonomy Filtered)

archive_taxonomy

Environment info

https://pastebin.com/h2ZrSsDN

Is the issue you are reporting a regression

No

@shadowsight-ss1 shadowsight-ss1 added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 10, 2024
selul added a commit that referenced this issue Aug 11, 2024
@vytisbulkevicius vytisbulkevicius linked a pull request Aug 14, 2024 that will close this issue
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants