Margin control for blocks not appearing when using Neve

[rodica-andronache]

Description

There is no way to add/edit margin for any block, when using Neve. This worked at some point, from what I remember, but even though I've tried it with a couple of versions of Neve, it still didn't worked

Step-by-step reproduction instructions

1. On a fresh instance with just Neve
2. Add any new block
3. Go to Style > Dimensions
4. Only the Padding control is available. Margin is missing

Screenshots, screen recording, code snippet or Help Scout ticket

How it works with any other theme

How it works with Neve ( Margin is missing )

https://fadebreath.s3-tastewp.com/wp-admin/
user: rodica
pass: rodica

Environment info

No response

Is the issue you are reporting a regression

No

[selul]

@vytisbulkevicius I see we added this here #4110, any reason why is no longer present? could be something related to 6.6?

[vytisbulkevicius]

The issue was introduced with 3.8.0 version of the theme - https://github.com/Codeinwp/neve/releases/tag/v3.8.0
With 3.7.5 it still works

[girishpanchal30]

Hey @vytisbulkevicius @selul,

I've tested with 3.7.4 and it seems not working either.

We need to add theme.json to control the dimensions settings.

e.g:

{
	"version": 2,
	"settings": {
		"spacing": {
			"margin": true,
			"padding": true
		}
	}
}

But I've checked previous some tickets regarding the remove theme.json file.

#3485

#3694

neve/readme.md

Line 572 in 511d347

- [Fix] Remove the theme.json file as it adds lots of other issues

Should I add a theme.json file, please let me know. After adding the theme.json file it will show the margin option as well.
Ref: https://tinyurl.com/277cbxxv

Thanks

[vytisbulkevicius]

Sorry, I confused you with the version here Girish is right. When I activated 3.7.5 I think it threw an error on the website and it didn't get activated which I didn't notice so another theme remained active that's why I was seeing the "margin".

[girishpanchal30]

@vytisbulkevicius Okay np, Please let me know your thoughts about the theme.json file.

[selul]

@vytisbulkevicius did we reverted the changes here at some time? #4110

[vytisbulkevicius]

I don't think so, if we check what was added by this PR - https://github.com/Codeinwp/neve/pull/4145/files

All those are still present https://github.com/Codeinwp/neve/blob/master/inc/core/front_end.php#L48

Also, if we reverted somewhere later, it means with that version where it was released - 3.7.4 it should be working but it's not :/

[selul]

@girishpanchal30 maybe you can check how that issue was implemented to fix this.

[girishpanchal30]

@selul If theme.json is causing issues, we can enable the margin setting using the following filter.

add_filter(
	'wp_theme_json_data_theme',
	function ( $json ) {
		$data = $json->get_data();
		// Add margin in theme.json.
		$data['settings']['spacing']['margin'] = true;
		$json->update_with( $data );
		return $json;
	}
);

Please let me know if that is fine then I'll add it to the neve theme default.

Thanks

[selul]

@girishpanchal30 can we use the same method implemented in the referenced issue?

[girishpanchal30]

The add_theme_support('custom-spacing'); feature is already included in the Neve theme, but it only enables the padding option.
Ref: https://github.com/search?q=repo%3ACodeinwp%2Fneve%20add_theme_support(%20%27custom-spacing%27%20)&type=code

[selul]

I think in this case we need to be careful with adding that as it might break some starter sites if it adds some default values based on what I see on other issues.

I suggest we put this on hold and close it until we have time to dig deeper.

[rodica-andronache]

still replicable