Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category description visible inside the submenu #4199

Closed
irinelenache opened this issue Jan 31, 2024 · 3 comments
Closed

Category description visible inside the submenu #4199

irinelenache opened this issue Jan 31, 2024 · 3 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@irinelenache
Copy link
Contributor

Description

If i have a category of posts that contains a description and that category is added as a submenu item, the description will also be visible.
Category as a top level menu item (Sports) https://vertis.d.pr/i/QYqq23
Category as a submenu item https://vertis.d.pr/i/f63ozY

Reported here - https://secure.helpscout.net/conversation/2495372301/402389?folderId=212385

Step-by-step reproduction instructions

  1. Create a post category and add a description for it
  2. Add the category in the primary menu as a top level item
  3. Add the category as a submenu item and see the description is also visible

Screenshots, screen recording, code snippet or Help Scout ticket

Category as a top level menu item (Sports) https://vertis.d.pr/i/QYqq23
Category as a submenu item https://vertis.d.pr/i/f63ozY

https://secure.helpscout.net/conversation/2495372301/402389?folderId=212385

Environment info

WordPress 6.4.2 / Neve 3.8.1 / Neve Pro 2.8.1

Is the issue you are reporting a regression

No

@irinelenache irinelenache added bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. labels Jan 31, 2024
@vytisbulkevicius
Copy link
Contributor

I tested this and wasn't able to find out when this was introduced, downgraded the theme till 3.0.0 and I still see the description in the menu submenu, so looks like it was always like this or for a long time.
Other popular themes don't show the description so we should address this.

@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Jan 31, 2024
@preda-bogdan
Copy link
Contributor

preda-bogdan commented Jan 31, 2024

This was introduced with the Mega Menu feature, and it happens because it automatically adds the item description even if the Mega Menu is not being used. It seems to be a bug since it was introduced. Will create a PR to address this, just wanted to add more context here.

@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

4 participants