Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode logo shown in light-mode on first visit #4087

Closed
poonam279 opened this issue Sep 5, 2023 · 3 comments
Closed

Darkmode logo shown in light-mode on first visit #4087

poonam279 opened this issue Sep 5, 2023 · 3 comments
Assignees
@cristian-ungureanu
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@poonam279
Copy link

Description

since the last update, when visiting the site for the first time, although the default state of the website is set to light-mode, logo specific for dark-mode is shown. The logo thing is fixed once you click pallete-switch button twice - then the logo is correct for each mode.

Step-by-step reproduction instructions

  1. Add palette-switcher in the header
  2. Add different logos for Light palette and Dark palette
  3. Check the logo in frontend
  4. You will see the Dark palette logo when visiting the site for the first time
  5. Now click the palette-switch button twice, and you will see the correct logo.

Screenshots, screen recording, code snippet or Help Scout ticket

https://secure.helpscout.net/conversation/2340909631/383091/

Environment info

No response

Is the issue you are reporting a regression

No
@poonam279 poonam279 added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 5, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Sep 5, 2023
@cristian-ungureanu cristian-ungureanu added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Sep 15, 2023
@cristian-ungureanu
Copy link
Contributor

Hey @poonam279, I am not able to replicate this issue. Here's what I've tried: https://vertis.d.pr/v/gsN6zh.
Please let me know if I'm doing something wrong. If you can replicate the issue, an explicit video would really help me.
Thank you!

@poonam279
Copy link
Author

Hey @cristian-ungureanu Can you please check after logging out from WordPress or use an incognito window?

cristian-ungureanu pushed a commit that referenced this issue Sep 18, 2023
fix: dark-mode logo shown in light-mode on first visit [#4087]
a253150
@cristian-ungureanu cristian-ungureanu added the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Sep 19, 2023
@cristian-ungureanu cristian-ungureanu mentioned this issue Sep 19, 2023
Merged
6 tasks
cristian-ungureanu pushed a commit that referenced this issue Oct 5, 2023
Merge pull request #4103 from Codeinwp/fix/light-dark-logo
3e17c25 
fix: dark-mode logo shown in light-mode on first visit [#4087]
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristian-ungureanu cristian-ungureanu

Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cristian-ungureanu @poonam279 @pirate-bot