Single post layout cover not working for CPT

[rodica-andronache]

Description

The Cover option that we have in Customize > Layout > Single Post > Header Layout is also applying for any CPTs created, but is not working well in that case ( the title and meta are not visible )

Step-by-step reproduction instructions

1. Create a CPT using Custom Post Type UI and check it on frontend https://vertis.d.pr/i/2PaKtt
2. Go to Customize > Layout > Single Post > Header Layout and change it to Cover
3. Check the CPT again -> the title is not visible anymore https://vertis.d.pr/i/ikjtME

In the video you can see the difference between how the Cover option is working for Posts vs CPT https://vertis.d.pr/v/yrpnu1

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

[irinelenache]

+1 https://wordpress.org/support/topic/cover-headers-for-custom-post/

[girishpanchal30]

@rodica-andronache Customizer Layout works for CPT if you have installed the neve-pro-addon plugin.

Without Pro: https://tinyurl.com/25vo97vp
With Pro: https://tinyurl.com/2cr92msw

In free it will work with posts and pages only.

@vytisbulkevicius Could you please ask the docs team to add a note to the Neve document?

Thanks

[vytisbulkevicius]

@girishpanchal30, to me it still looks more like a bug as we change how custom post type looks like when Cover is selected and there is no way to keep the default option for them to keep the title visible.

So my understanding if we want to keep this as a PRO feature would be to keep the default option for the CPT so title can be visible and it's not affected by the changes OR to make it work for custom post types as well based on the available selection in customizer.

@selul, what do you think?

[selul]

I think the cpts should be not affected by this since the setting and use the default is for post post_type

[vytisbulkevicius]

Yes, so @girishpanchal30 the goal here is to make sure that those changes in customizer don't make affect to CPTs but when working on this we need to be careful that we don't break the functionality of Neve PRO.

[girishpanchal30]

@vytisbulkevicius I've enabled the use of the cover layout for CPT without affecting the features of Neve PRO.
Please review this PR and let me know if you find any issues.

Thanks

[rodica-andronache]

@girishpanchal30 now it works the same with or without PRO. The Normal/Cover layouts apply to CPTs in the same way as it does for posts. @vytisbulkevicius is this the expected behaviour? From your latest message I understood that this should work just in PRO.

[girishpanchal30]

@rodica-andronache, After reviewing the features and reconsidering, the cover layouts feature should work only when the pro addon is activated.

I've made some modifications with the latest commit, please recheck with the build zip and let me know if you find any issues.

Thanks

[rodica-andronache]

@girishpanchal30

• when using just Neve, with the Cover header layout, the header gets duplicated for normal posts https://vertis.d.pr/i/iNBYia
• when using just Neve, with both the Cover and Normal header layout, the header area for CPTs doesn't have the same alignment as normal posts. I think it should act the same? https://vertis.d.pr/i/u1hcKy https://vertis.d.pr/i/PguN6N

[girishpanchal30]

@rodica-andronache I have resolved both issues in the latest commit. Please review it and let me know if you encounter any problems.

[rodica-andronache]

@girishpanchal30 now those two issues are fixed, but it's something else.
When using Neve and Neve Pro, following the steps in the video (possibly in other cases as well), at some point, the title of the norma post disappears:

https://vertis.d.pr/v/GYKpob

1. create a post
2. change the Header Layout from Customizer to Cover -> everything is ok
3. change the Title alignment from the single post options -> everything is ok
4. change the Header Layout from Customizer to Normal -> the post title is gone

[selul]

@vytisbulkevicius I suggest putting this on hold, is getting too complicated and too much effort is spent for something that is not that critical right now.

[pirate-bot]

🎉 This issue has been resolved in version 3.8.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[rodica-andronache]

this is still replicable

[vytisbulkevicius]

This was not released as we put it on hold. I accidentally merged PR before but reverted it, so code changes were not applied during the release. It can be worked on during the PRF if prioritized.