You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user mentioned on the forum that Neve doesn't add any margin to the buttons in the page content and that Gutenberg blocks should have a margin. I need help here as I don't know if it's a guideline in this regard or not.
What I did is to use the button block from WP and the buttons group block from Otter, and none of the allows the user to set a margin for the buttons. Compared to Neve, the Twenty Twenty-One theme seems to add margin to all the blockw within the page content with the * CSS selector.
Neve
Twenty Twenty-One
Step-by-step reproduction instructions
Add a button from WordPress
Add some content above and below it, like text
Try adding some margin around the buttons - there is no such option; I didn't find it in the Otter Buttons Group block either.
Screenshots, screen recording, code snippet or Help Scout ticket
The text was updated successfully, but these errors were encountered:
stefan-cotitosu
added
the
question
Can be used to identify issues that are asking a question about the code or how to use the project.
label
Apr 18, 2023
stefan-cotitosu
changed the title
No margin bottom for buttons
No margin bottom for buttons in content with the WP editor
Apr 18, 2023
@stefan-cotitosu No, this isn't a guideline issue and themes can decide if they need to do it or not. Normally buttons should have top/bottom margin but the Paragraph in Neve has a lot of bottom margin (#3865) so the need is only for the bottom margin.
We don't need to do anything here but I'll take some feedback from @Codeinwp/design-team if they ever face this as an issue when making templates?
I guess we can check what other themes like Astra, Blocky are doing regarding this (from a quick research I see Astra isn't adding something, while Blocksy does add bottom margin, and 2022 adds top margin).
But from a normal user/designer point of view, fixing this may cause other issues. Meaning that right now, it's possible to add a spacer and the problem is fixed. But if we add the bottom margin by default - removing it will require some workarounds from the user.
Description
A user mentioned on the forum that Neve doesn't add any margin to the buttons in the page content and that Gutenberg blocks should have a margin. I need help here as I don't know if it's a guideline in this regard or not.
What I did is to use the button block from WP and the buttons group block from Otter, and none of the allows the user to set a margin for the buttons. Compared to Neve, the Twenty Twenty-One theme seems to add margin to all the blockw within the page content with the * CSS selector.
Neve
Twenty Twenty-One
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet or Help Scout ticket
https://wordpress.org/support/topic/wp-block-button__link-should-have-margin/
Environment info
Not relevant for this case
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: