Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify fillet and chamfer operations #219

Open
shehabattia96 opened this issue Oct 27, 2023 · 0 comments
Open

Simplify fillet and chamfer operations #219

shehabattia96 opened this issue Oct 27, 2023 · 0 comments
Labels
Breaking Change This issue will cause a breaking change in one or more CodeToCAD providers Core This issue affects CodeToCAD core modules good first issue Good for newcomers

Comments

@shehabattia96
Copy link
Member

shehabattia96 commented Oct 27, 2023 •
edited
Loading

Right now we have:
fillet_edges
fillet_all_edges
fillet_faces
fillet_all_faces

These can all be simplified into single fillet method, where providing no edges fillets ALL the edges (which is equivalent to all faces), and providing the edges that make up a face would fillet a face.

Then do the same thing for the chamfer methods.
@shehabattia96 shehabattia96 added good first issue Good for newcomers Breaking Change This issue will cause a breaking change in one or more CodeToCAD providers Core This issue affects CodeToCAD core modules labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change This issue will cause a breaking change in one or more CodeToCAD providers Core This issue affects CodeToCAD core modules good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shehabattia96