Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update travis ci build tag #32

Closed
wants to merge 3 commits into from
Closed

Update travis ci build tag #32

wants to merge 3 commits into from

Conversation

NickSchimek
Copy link
Contributor

Configured travis ci and hound bot for the repo

Updated the travis ci build tag to point to CodeForPortland's consul
build.

Fixes #25

@NickSchimek
Update travis ci build tag
a8dfa56 
Configured travis ci and hound bot on github

Updated the travis ci build tag to point to code-for-portland's consul
build.
@NickSchimek NickSchimek self-assigned this Mar 6, 2019
@NickSchimek
Copy link
Contributor Author

@htharker42 I integrated travis ci, however there are some failing tests. Some that are failing are fragile tests as they're testing for exact content on the view. Other tests are failing due to missing elements on the page... Most likely not a big issue since all the tests seem to be view related.

There are two tests that are failing due to missing translations. These started to fail when the twilio-ruby gem was added to the gemfile. Not sure how you want to proceed here. Any thoughts?

  2) I18n does not have missing keys
     Failure/Error:
       expect(missing_keys).to be_empty,
         "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
     
       Missing 1 i18n keys, run `i18n-tasks missing' to show them
     # ./spec/i18n_spec.rb:10:in `block (2 levels) in <top (required)>'
  3) I18n does not have unused keys
     Failure/Error:
       expect(unused_keys).to be_empty,
         "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
     
       8 unused i18n keys, run `i18n-tasks unused' to show them
     # ./spec/i18n_spec.rb:15:in `block (2 levels) in <top (required)>'

@NickSchimek NickSchimek deleted the doc/update_travis_link branch September 30, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NickSchimek NickSchimek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add continuous integration
1 participant
@NickSchimek