Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens when clicking "accept" for accepting a project application #1829

Open
SunyataZero opened this issue Apr 24, 2018 · 9 comments
Assignees
Labels

Comments

@SunyataZero
Copy link
Collaborator

Steps to reproduce:

  1. Login as a organizational user
  2. Go to a project page that you have created, and where there is a user that has sent in an application which you have not accepted yet
  3. Click on the "accept" button
  4. Result: There is a "click response" for the button, but other than that nothing happens, in other words the checkmark doesn't change to a double checkmark like expected

Please note:

  • I've tried on two different projects
  • This wasn't a problem before
  • I've tried on both Firefox and Chrome (latest versions, and i'm running Lubuntu 17.10)

Console output:

@zhufeilong
Copy link
Collaborator

spot the problem caused by the followed codes in auth.service.ts, but I don't know how to get the right access_token when using email login.

` // email signups do not readily return a usable JWT, so we need to grab
// the temporary token. social sign ups, however, do return the jwt, so we
// don't do anything special in this case.

      try {
          jwtHelper.decodeToken(authResult.accessToken);
      } catch (e) {
          localStorage.setItem('access_token', authResult.idTokenPayload['http://tempToken']);
      }`

@zhufeilong zhufeilong removed their assignment Apr 29, 2018
@felipealvesgnu felipealvesgnu self-assigned this May 28, 2018
@felipealvesgnu
Copy link
Collaborator

@SunyataZero which URL did you try ? That happens on DEV or PROD environment ?

@SunyataZero
Copy link
Collaborator Author

@felipealves-gnu Hi, it was in PROD (the live website). Not sure about the URL, haven't kept that data from when i tested, do you not get the same problem if following the steps to reproduce the problem? Kind Regards, Tord

@SunyataZero
Copy link
Collaborator Author

Hi i still have this problem, i get "EXCEPTION: JWT must have 3 parts" on firefox on my Lubuntu system. (Haven't looked at other browsers/systems)

@SunyataZero SunyataZero reopened this Jun 23, 2018
@felipealvesgnu
Copy link
Collaborator

@SunyataZero can you send a print screen with this error happening on your browser, please ?

@SunyataZero
Copy link
Collaborator Author

@felipealves-gnu Well it doesn't show anything, the only thing that happens is that the application is not accepted:

image

So nothing really happens except for a small click response on the button

Do you want me to try using chrome or another browser? Something else i can do?

@felipealvesgnu
Copy link
Collaborator

@SunyataZero yes try with chrome. But before click on the button please go to 3 on the upper right side (on chrome) -> More tools -> Developer tools. You will see a bar on the bottom, so then you choose NETWORK (and check an option called "Preserve log") check the requests made after the click action. So copy and make a screen shot, please

@SunyataZero
Copy link
Collaborator Author

@felipealves-gnu I'm having the same problem on Chrome. Just installed it so there cannot be a chache problem (new OS, new installation of Chrome). Have you tested this yourself and it works for you?

Here's the logs for Chrome:

At reload of webpage: at-reload_app.code4socialgood.org-1530358201733.log

At accept of application: at-accept_app.code4socialgood.org-1530358241213.log

(Screenshot is same as above, in other words nothing happens except the graphical click response)

Btw my OS is Lubuntu 18.04 64-bit (more or less the same as Ubuntu 18.04 64-bit)

@SunyataZero
Copy link
Collaborator Author

SunyataZero commented Aug 14, 2018

Now when i try to accept an application it gives me an error message in the upper right corner, but after i reload the page the application has been accepted


On another note: I have looked at another issue and through that found that we need to update the auth0 and lock js lib versions. When i check the source i can see this:

  <script src="https://cdn.auth0.com/js/lock/10.8/lock.min.js"></script>
  <script src="https://cdn.auth0.com/js/auth0/8.8/auth0.min.js"></script>

But we need to upgrade to a later version. See this announcement for more info

In short, if things are like they were in the other issue we may only need to upgrade the 10.8 and 8.8 to a newer version. Searching the code i think this is the only place where these libs are used: https://github.com/Code4SocialGood/c4sg-web/blob/master/src/index.html (But please check for yourselves of course, i don't have an understanding of the code for the project as a whole)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants