Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Pull Request Event Handler" #63

Open
Durgesh4993 opened this issue Mar 24, 2024 · 1 comment
Open

Update "Pull Request Event Handler" #63

Durgesh4993 opened this issue Mar 24, 2024 · 1 comment

Comments

@Durgesh4993
Copy link

It seems like you're trying to create an event handler for pull requests (PRs). If I understand correctly, you're filtering events based on their actions. there are a few points you might want to consider:

Error Handling: The code assumes that the input eventData is properly formatted and contains the expected keys. You might want to include error handling to ensure that the necessary keys are present and have the expected data types.

Return Values: In the handleEvent method, you currently have a return statement after filtering out certain events. This effectively ends the method execution. If you intend for the method to continue processing after filtering out certain events, you should remove the return statement.

Logging or Error Reporting: Instead of directly printing messages within the handleMerged and handleAbandoned methods, you might want to consider using a logging framework or some form of error reporting mechanism. This allows for better flexibility and control over how messages are handled.

beautify-picture

@Durgesh4993
Copy link
Author

@KDwevedi Can i work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant