Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] - Some suggestions. Localization, UI and other. #14

Open
Furukia opened this issue Jul 27, 2024 · 4 comments
Open

[REQUEST] - Some suggestions. Localization, UI and other. #14

Furukia opened this issue Jul 27, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Furukia
Copy link

Furukia commented Jul 27, 2024

Requests

  • Localization support would be cool. I love localizing modules for my players, and here i can't do it, which is a kinda sad. Also i can help you with russian localization later if you are interested.
  • A bool setting to allow/disallow changing journal ownership for a player. Instead of always opening journals for them.
  • An ability to toggle whether the macro should be run as a GM proxy, instead of always running as a GM.
    • Note: right now running a macro with no proxy can be achieved by using monk's tile triggers, but it's a workaround and the name of the button becomes "RUN SCRIPT". Customizing this name would be cool.
  • An ability to customize "PERSONAL TERMINAL" and "FOLDERS" text in terminal.
  • A better selector menu's? selecting macros or journals is a pain when you have like a hundred of them... Suggestions:
    • Add a simple search
    • Respect foundry folder structure and display it in some way
    • Alternatively sort list elements alphabetically
    • Maybe you can change or add a second button to select journals/macros similar to Monk's active tile's way. Where you just click on a macro/journal to bind it. You already do a similar thing with doors.
  • If item requirement to access terminal is set - display what item(s) needed to the player.
    • Also allow toggling this behaviour
  • Foundry v12 introduced regions. integrating them in some way would be cool. Suggestions:
    • A similar to macros approach, where you bind regions to console, and call their behaviour via button.
    • As a "detection zones", that replaces "detection range" when added.
    • As a zone which activates the tile's terminal. (Honestly stepping on a computer tile to start up console is not very immersive)
@CodaBool
Copy link
Owner

CodaBool commented Jul 27, 2024

Localization support

Localization support would be incredible. If you are willing to do localization for Russian I would absolutely pay for that. We can use a public Google sheet where the first column is English and any amount of new columns for whatever language can be added. I created a quick Sheet here: https://docs.google.com/spreadsheets/d/1l1itWxpfGLXtsNsX-sr3zkOlt0j4BxHh4g-nrksfDaU/edit?usp=sharing but I'll need some time to dump in the existing English text

A bool setting to allow/disallow changing journal ownership for a player

I'm not totally convinced this would be all that useful for the amount of code this would require (the way Terminal currently checks for ownership and generates buttons is already somewhat complicated).

I'd recommend trying out two skill check settings and seeing if this works for you. There are the "at login" and "add encryption" skill checks. With these on it will allow you as the GM to hide the journal or pages behind a roll check. At which point to make things simple you could state to your players that it is an impossible task if you were wanting them to just move on and not attempt to view that journal/page.

An ability to toggle whether the macro should be run as a GM proxy

A toggle on using a GM proxy would be pretty useful. I can add that to my todo list.

The name of the button becomes "RUN SCRIPT". Customizing this name would be cool.
An ability to customize "PERSONAL TERMINAL" and "FOLDERS" text in terminal.

There is something already in the works for renaming the Run Script text. I can add support for customizing "PERSONAL TERMINAL" and "FOLDERS" as well.

Just keep in mind these changes are going to get bundled with a major rewrite (a version 3.0 for Terminal) to AppV2 and UUID support (I'm already using AppV2 in some spots but not for the actual Terminal app window). Which will have many major breaking changes. Meaning I will be conducting testing on it to maximize stability for maybe another month.

A better selector menu

Right, this is pretty needed. I think respecting Foundry folders would probably be the best solution.

EDIT: this has been added, see comment below

If item requirement to access terminal is set - display what item(s) needed to the player.

That shouldn't be too hard to implement and would be an improvement.

Regions

I really love that Foundry added Regions. It absolutely will be a high priority to support integration with anything cool that comes out for Regions

  • The way that Regions can have their own darkness level is very interesting
  • The first party teleport feature is also huge

That being said I don't want to get burned by supporting them too early. I want Regions to mature a little before I code out a lot of useful integrations.
There are really only a few things that you can do with Regions at the moment. I'm guessing a Foundry V13 will add more things. At which point I will be adding integrations.

As a zone which activates the tile's terminal

I do include a macro in the compendium if you wanted to start Terminal from an external source (run macro action)

@CodaBool
Copy link
Owner

A better Actor & Macro selector is here!

I've pushed out a live update, version 2.6.5

I actually found a completely different method for selecting journals and macros. It's pretty slick since it injects into the Foundry API method listeners. Which is somewhat dangerous but I wrapped in it a try catch, so should be fine. I migrated item and actor selection over to this new method.

Pretty useful going forward.

This should resolve any issues with large numbers of macros or journals. Since you they use the native Foundry UI which has folders AND a search.

@CodaBool CodaBool added the enhancement New feature or request label Jul 27, 2024
@Furukia
Copy link
Author

Furukia commented Jul 28, 2024

Localization support would be incredible. If you are willing to do localization for Russian I would absolutely pay for that. We can use a public Google sheet where the first column is English and any amount of new columns for whatever language can be added.

Paying can be a problem, because i live in Russia. Even buying your module was kinda a challenge for me... I am willing to help with localization for free tho.
The best way to work on localization for me would be straight up working with localization .json files. But you first need to support it first, by localizing your module in english using foundry's localization system. Right now all your strings are hard-coded.
If you want to create all localization files yourself, i can work with google sheets tho.

Here's some helpfull link about localization in foundry:

I'm not totally convinced this would be all that useful for the amount of code this would require (the way Terminal currently checks for ownership and generates buttons is already somewhat complicated).

I am not sure it requires any heavy modifications for it. You basicly need to skip the step of updating ownership if setting is off. Setting up EVERY terminal to use skill check blocks is more work and also if there are many terminals, gm would be bombarded with notifications, which is not cool.

Just keep in mind these changes are going to get bundled with a major rewrite (a version 3.0 for Terminal)

No worries, i am just glad to see a good project evolve to be better.

A better Actor & Macro selector is here!

Tested. Works like a charm.

@CodaBool
Copy link
Owner

I'm guessing a Foundry V13 will add more things. At which point I will be adding integrations.

Added region support early (v3.1.2). For now it's just triggering behaviors. But that already should open plenty of chances for GMs to do scripting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants