Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit handling code is slow #75

Closed
mcgibbon opened this issue Aug 20, 2018 · 3 comments
Closed

Unit handling code is slow #75

mcgibbon opened this issue Aug 20, 2018 · 3 comments

Comments

@mcgibbon
Copy link
Member

@JoyMonteiro brought up that currently when run in SCM mode, unit conversion checking takes up a significant amount of CliMT's runtime. We may want to add a faster backend for unit handling.

@JoyMonteiro
Copy link
Member

I don't mind spending some time profiling different libraries. Which ones do you suggest?

Also, this library would need to be registered with sympl. Do you propose adding an API to
do this, or will it replace pint as a dependency?

@mcgibbon
Copy link
Member Author

I'll need to write an internal backend API and wrappers for each library. This would technically make pint an optional dependency, but I'd say we should keep it as is to make sure there is at least one unit library installed, because it is pure Python with few dependencies of its own. We could default to cfunits when it is present.

@mcgibbon
Copy link
Member Author

Let's move discussion over to an issue on Sympl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants