-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TagBot trigger issue #14
Comments
Triggering TagBot for merged registry pull request: JuliaRegistries/General#44816 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#45841 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#50568 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#50646 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#52410 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#53413 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#53417 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#56801 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#58820 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#61205 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#62080 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#62570 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#64791 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#64783 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#65305 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#67079 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#67161 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#68303 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#68573 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#70618 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#71189 |
75: Add beta factor to evaporation r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Co-authoured-by: `@LenkaNovak` `@kmdeck` Adds a beta factor to evaporation when surface condition is `ValuesOnly` or `Coefficients` to account for surface resistance. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
Triggering TagBot for merged registry pull request: JuliaRegistries/General#74358 |
78: use relative or absolute tolerance for obukhov length r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Try to fix #62 and ClimaAtmos [#1225](CliMA/ClimaAtmos.jl#1225) ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
79: fix an error in tolerance argument r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Fixes the argument order bug introduced in #78. Also slightly increase the relative tolerance. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
80: Update patch version r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Update patch version to v0.5.1. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
Triggering TagBot for merged registry pull request: JuliaRegistries/General#75552 |
90: Make initial guess of l_mo dependent on stability regimes r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Closes #89 ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
91: Update minor version r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
Triggering TagBot for merged registry pull request: JuliaRegistries/General#75998 |
94: Change initial guess of L_MO to -1 r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Currently SurfaceFluxes breaks some of the EDMF cases in ClimaAtmos. I don't think it is a problem with SurfaceFluxes, but I would like to upgrade the dependencies in ClimaAtmos. Therefore I'm changing the initial guess of L_MO back to the default -1. cc `@akshaysridhar` ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
95: Bump patch version r=szy21 a=szy21 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: Zhaoyi Shen <[email protected]>
Triggering TagBot for merged registry pull request: JuliaRegistries/General#80076 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#81018 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#84039 |
103: Add Bonan plots to documentation r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add plots reproducing Figs 6.3(a),(b) from [Bonan (2019)](https://doi.org/10.1017/9781107339217.007) to existing documentation. <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: gdecker1 <[email protected]>
104: Added tests for GLSG21 Eq. 2 and Eq. 3 r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add edge case tests for [Gryanik (2021)](https://doi.org/10.1029/2021MS002590) Eq. 2 and Eq. 3 to existing test set. <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: gdecker1 <[email protected]>
101: Implementation of Holtslag SCFs r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add stability correction functions from Holtslag and De Bruin (1988) into ```UniversalFunctions.jl```. Here is a [visual tabulation](https://docs.google.com/document/d/1T2krlLtTR-WMaMpYOvUqlcOWm2GK3-P5tluCzHc9ibg/edit?usp=sharing) of the equations in ```UniversalFunctions.jl``` for ease of reference. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> - [x] Implement Holtslag SCF (phi) momentum and heat functions - [x] Implement Holtslag integrated-SCF (psi) momentum and heat functions - [x] Implement Holtslag volume-averaged integrated-SCF (Psi) momentum and heat functions - [x] Add Holtslag to docs - [x] Add Holtslag-specific asymptotic tests (phi equations diverge to infinity) <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: gdecker1 <[email protected]>
107: Add Comprehensive Set of Universal Functions to Docs r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add the full set of universal functions implemented in ```UniversalFunctions.jl``` to existing docs, reproducing [this visual tabulation](https://docs.google.com/document/d/1T2krlLtTR-WMaMpYOvUqlcOWm2GK3-P5tluCzHc9ibg/edit?usp=sharing). ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> - [x] Add [Businger (1971)](https://doi.org/10.1175/1520-0469(1971)028%3C0181:FPRITA%3E2.0.CO;2) universal functions to docs - [x] Add [Grachev (2007)](https://doi.org/10.1007/s10546-007-9177-6) universal functions to docs - [x] Add [Gryanik (2021)](https://doi.org/10.1175/JAS-D-19-0255.1) universal functions to docs - [x] Add [Cheng (2005)](https://doi.org/10.1007/s10546-004-1425-4) universal functions to docs #100 - [x] Add [Holtslag (1988)](https://doi.org/10.1175/JAS-D-19-0255.1) universal functions to docs #101 - [x] Add [Beljaars (1991)](https://doi.org/10.1175/1520-0450(1991)030%3C0327:FPOLSF%3E2.0.CO;2) universal functions to docs #102 - [ ] Add commentary for each universal function <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: gdecker1 <[email protected]>
100: Implementation of Cheng SCFs r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add stability correction functions from Cheng and Brutsaert (2005) into ```UniversalFunctions.jl```. Here is a [visual tabulation](https://docs.google.com/document/d/1T2krlLtTR-WMaMpYOvUqlcOWm2GK3-P5tluCzHc9ibg/edit?usp=sharing) of the equations in ```UniversalFunctions.jl``` for ease of reference. ## To-do - [x] Implement Cheng SCF (phi) momentum and heat functions - [x] Implement Cheng integrated-SCF (psi) momentum and heat functions - [x] Implement Cheng volume-averaged integrated-SCF (Psi) momentum and heat functions (Add error message as of now; complete implementation requires hypergeometric function) - [x] Add Cheng to docs - [x] Add Cheng-specific asymptotic tests <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: gdecker1 <[email protected]>
102: Implementation of Beljaars SCFs r=akshaysridhar a=gdecker1 <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> Add stability correction functions from Beljaars and Holtslag (1991) into ```UniversalFunctions.jl```. Here is a [visual tabulation](https://docs.google.com/document/d/1T2krlLtTR-WMaMpYOvUqlcOWm2GK3-P5tluCzHc9ibg/edit?usp=sharing) of the equations in ```UniversalFunctions.jl``` for ease of reference. ## To-do <!--- list of proposed tasks in the PR, move to "Content" on completion - Proposed task --> - [x] Implement Beljaars SCF (phi) momentum and heat functions - [x] Implement Beljaars integrated-SCF (psi) momentum and heat functions - [x] Implement Beljaars volume-averaged integrated-SCF (Psi) momentum and heat functions - [x] Add Beljaars to docs - [x] Add Beljaars-specific asymptotic tests (phi equations diverge to infinity) <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: akshaysridhar <[email protected]>
Triggering TagBot for merged registry pull request: JuliaRegistries/General#90599 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#90653 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#90887 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#93738 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#98473 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#99211 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#99477 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#100883 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#101397 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#101580 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#101954 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#102479 |
Triggering TagBot for merged registry pull request: JuliaRegistries/General#115457 |
This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your
TagBot.yml
to include issue comment triggers.Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment
TagBot fix
on this issue.I'll open a PR within a few hours, please be patient!
The text was updated successfully, but these errors were encountered: