Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Unnecessary inflexibility in building the sampler #423

Open
odunbar opened this issue Nov 22, 2024 · 0 comments
Open

Remove the Unnecessary inflexibility in building the sampler #423

odunbar opened this issue Nov 22, 2024 · 0 comments

Comments

@odunbar
Copy link
Collaborator

odunbar commented Nov 22, 2024

Currently the get_obs function with build=true, creates a vector with a length based on the first observation, rather than requesting each observation in turn - this is a simple fix that will allow different sized minibatchers

sample_length = length(get_obs(observations_vec[1], build = true))
minibatch_samples = zeros(sample_length * minibatch_length)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant