Add postprocessing for 4D variables (lat, lon, time, pressure level) #1094
Conversation
ph-kev
force-pushed
the
kp/pressure-postprocessing
branch
from
4461dfe
to
97ff662
Compare
| @@ -48,3 +48,6 @@ must be initialized for each variable of interest. The CliMA model is added with | |||
| the `RMSEVariable`. It is assumed that the `RMSEVariable` contains only the columns "DJF", | |||
| "MAM", "JJA", "SON", and "ANN" in that order. The file `leaderboard.jl` will load the | |||
| appropriate data into the `RMSEVariable`. | |||
|
|
|||
| ### Add a new variable to compare against observations in pressure coordinates | |||
There was a problem hiding this comment.
It would be good to also add a description of the new feature in NEWS.md
| @@ -153,11 +160,151 @@ function compute_leaderboard(leaderboard_base_path, diagnostics_folder_path) | |||
| CairoMakie.save(joinpath(leaderboard_base_path, "bias_leaderboard.png"), fig_leaderboard) | |||
| end | |||
|
|
|||
| """ | |||
| compute_pfull_leaderboard(leaderboard_base_path, diagnostics_folder_path) | |||
There was a problem hiding this comment.
What does pfull refer to here? If it's referring to the space the data is on, 4d might be more clear unless you want to distinguish between using P or z as the 4th dimension
There was a problem hiding this comment.
I am using pfull to refer to full pressure levels since the variables have the dimensions longitude, latitude, time, and pressure levels. I am going to add it to the docstring, so it is more clear what the function needs.
| function that returns a `OutputVar`. The function must takes in a start date | ||
| which is used to align the times in the observational data to match the | ||
| simulation data. The short name must be the same as in `sim_var_dict` in the | ||
| function `sim_var_dict`. Any preprocessing is done in the function which |
There was a problem hiding this comment.
| function `sim_var_dict`. Any preprocessing is done in the function which | |
| function `get_sim_var_dict`. Any preprocessing is done in the function which |
There was a problem hiding this comment.
Which function does the preprocessing + unit conversion + date shifting? It's not totally clear to me here
There was a problem hiding this comment.
I am going to rewrite this, but the function that does the post processing is the anonymous function defined in the dictionaries. For example, get_sim_var_dict returns a dictionary that map short names to functions and those functions are the one that do the preprocessing (unit conversion and data shifting).
ph-kev
force-pushed
the
kp/pressure-postprocessing
branch
2 times, most recently
from
20d997a
to
4f11200
Compare
The plots added are bias plots at 850 hPa, 500 hPa, and 250 hPa and lat - pressure plots.
ph-kev
force-pushed
the
kp/pressure-postprocessing
branch
from
4f11200
to
fdc3a5d
Compare
Purpose
closes #1093 - This PR adds postprocessing for 4D variables (lat, lon, time, pressure level). See plots below.
To-do
Content
Add bias plots after taking time average and slicing at specific pressure levels (850, 500, 250 hPA)
Add bias plots over latitude and pressure level after taking average over time and longitude
I have read and checked the items on the review checklist.
