Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit_diffusion can be turned on without a turbconv model and with vert_diff = false #3360

Open
Sbozzolo opened this issue Oct 3, 2024 · 2 comments

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Oct 3, 2024

And if you do so, you'll get the error

ERROR: LoadError: type NamedTuple has no field ᶜK_u
Stacktrace:
  [1] getproperty
    @ ./Base.jl:37 [inlined]
  [2] macro expansion
    @ ~/repos/ClimaAtmos.jl/src/prognostic_equations/implicit/implicit_solver.jl:400 [inlined]
  [3] Wfact!(A::ClimaAtmos.ImplicitEquationJacobian{…}, Y::FieldVector{…}, p::ClimaAtmos.AtmosCache{…}, dtγ::Float64, t::Float32)
    @ ClimaAtmos ~/.julia/packages/NVTX/pfSOQ/src/macro.jl:194
  [4] step_u!(int::ClimaTimeSteppers.DistributedODEIntegrator{…}, cache::ClimaTimeSteppers.RosenbrockCache{…})
    @ ClimaTimeSteppers ~/.julia/packages/ClimaTimeSteppers/Na6yl/src/solvers/rosenbrock.jl:134
  [5] macro expansion
    @ ~/.julia/packages/ClimaTimeSteppers/Na6yl/src/integrators.jl:265 [inlined]
  [6] step_u!(integrator::ClimaTimeSteppers.DistributedODEIntegrator{…})
    @ ClimaTimeSteppers ~/.julia/packages/NVTX/pfSOQ/src/macro.jl:194
  [7] __step!(integrator::ClimaTimeSteppers.DistributedODEIntegrator{…})
    @ ClimaTimeSteppers ~/.julia/packages/ClimaTimeSteppers/Na6yl/src/integrators.jl:237

instead of an informative error telling you that it doesn't make sense

@szy21
Copy link
Member

szy21 commented Oct 4, 2024

Just to clarify, we should be able to turn on implicit diffusion without a turbconv model. What doesn't make sense is to have implicit_diffusion with both vert_diff: false and turbconv: nothing.

@Sbozzolo Sbozzolo changed the title implicit_diffusion can be turned on without a turbconv model implicit_diffusion can be turned on without a turbconv model and with vert_diff = false Oct 4, 2024
@Sbozzolo Sbozzolo changed the title implicit_diffusion can be turned on without a turbconv model and with vert_diff = false implicit_diffusion can be turned on without a turbconv model and with vert_diff = false Oct 4, 2024
@Sbozzolo
Copy link
Member Author

Sbozzolo commented Oct 4, 2024

Just to clarify, we should be able to turn on implicit diffusion without a turbconv model. What doesn't make sense is to have implicit_diffusion with both vert_diff: false and turbconv: nothing.

Thank you, I updated the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants