Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status bar while downloading files #68

Open
sriharshakandala opened this issue Nov 9, 2024 · 8 comments · May be fixed by #76
Open

Add status bar while downloading files #68

sriharshakandala opened this issue Nov 9, 2024 · 8 comments · May be fixed by #76
Assignees

Comments

@sriharshakandala
Copy link
Member

Feature request

When downloading large files, It would be very helpful to have a status bar indicating the status of the download.

cc: @Sbozzolo @charleskawczynski

@sriharshakandala sriharshakandala changed the title Add status bar while downloading filles Add status bar while downloading files Nov 9, 2024
@Sbozzolo
Copy link
Member

Sbozzolo commented Nov 9, 2024 via email

@charleskawczynski
Copy link
Member

And maybe the download rate? (If this is possible)

@Sbozzolo
Copy link
Member

I tried to look at it and I couldn't find support for this in Downloads.jl, unfortunately.

@charleskawczynski
Copy link
Member

charleskawczynski commented Nov 13, 2024

The progress or the download rate? (or both?)-- bummer either way

@Sbozzolo
Copy link
Member

Downloads.jl, as far I can tell, supports no online reporting.

@imreddyTeja
Copy link
Contributor

I made a very simple download progress print out here:

function download_progress(total::Integer, now::Integer)
if total == 0
print("Downloaded $(round(now/10^9, digits=2)) GB \r")
else
print(
"Downloaded $(round(now/10^9, digits=2)) out of $(round(total/10^9, digits=2)) GB: $(div(now * 100, total))% \r",
)
end
end

That looks like this:

progress.mov

A very basic progress bar could look like:

progress_bar.mov

@Sbozzolo
Copy link
Member

I made a very simple download progress print out here:

function download_progress(total::Integer, now::Integer)
if total == 0
print("Downloaded $(round(now/10^9, digits=2)) GB \r")
else
print(
"Downloaded $(round(now/10^9, digits=2)) out of $(round(total/10^9, digits=2)) GB: $(div(now * 100, total))% \r",
)
end
end

That looks like this:

progress.mov
A very basic progress bar could look like:

progress_bar.mov

Awesome! I didn't see the progress argument to the Downloader object. Yes, we can build something with this

@sriharshakandala
Copy link
Member Author

Thanks @imreddyTeja ! This looks good. The first version itself is good and provides the needed status information. If you prefer the second version, that's also fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants