Replace the old pathfinding_settings with two new classes #77693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
CLIDragon
force-pushed
the
pathfinding-settings
branch
from
e2a6fe5 to
1e66873
Compare
github-actions
bot
added
json-styled
CLIDragon
force-pushed
the
pathfinding-settings
branch
from
1e66873 to
18e5d81
Compare
github-actions
bot
added
the
Mutations / Traits / Professions/ Hobbies
CLIDragon
force-pushed
the
pathfinding-settings
branch
from
18e5d81 to
0a9b8e8
Compare
PathfindingSettings is the direct replacement for the old struct. It stores how the creature will react to a given terrain, and what actions they can take. RealityBubblePathfindingSettings contains settings that govern z-level movement and parameters related to pathfinding, such as the maximum path cost. Currently the extra features of these two classes are completely unused, as they are intended for integration with the new pathfinder. Co-authored-by: prharvey <[email protected]>
CLIDragon
force-pushed
the
pathfinding-settings
branch
from
0a9b8e8 to
5aa4eac
Compare
github-actions
bot
removed
the
astyled
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const pathfinding_settings &settings, | ||
| const std::function<bool( const tripoint_bub_ms & )> &avoid = []( const tripoint_bub_ms & ) { | ||
| const PathfindingSettings &settings, | ||
| const std::function<bool( const tripoint_bub_ms & )> &avoid = []( const tripoint_bub_ms& ) { |
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
Suggested change
| const std::function<bool( const tripoint_bub_ms & )> &avoid = []( const tripoint_bub_ms& ) { | |
| const std::function<bool( const tripoint_bub_ms & )> &avoid = []( const tripoint_bub_ms & ) { |
|
Please resolve clang-tidy errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Work towards finishing #75945.
Describe the solution
PathfindingSettingsis the direct replacement for the old struct. It stores how the creature will react to a given terrain, and what actions they can take.RealityBubblePathfindingSettingscontains settings that govern z-level movement and parameters related to pathfinding, such as the maximum path cost.Currently the extra features of these two classes are completely unused, as they are intended for integration with the new pathfinder.
Describe alternatives you've considered
Testing
Additional context