Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[innawood] Add makeshift hand-crank charger and magnetite ore #78844

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Entott
Copy link
Contributor

@Entott Entott commented Dec 30, 2024

Summary

Mods "[innawood] Add Makeshift hand-crank charger and magnetite ore."

Purpose of change

Right now it is impossible to reach an electricity era in this mod. You can't charge any battery without having a charged soldering iron. Also clay car battery is the only battery you can craft without electronics 5 skill, which is unreachable without charged soldering iron.

Describe the solution

A makeshift hand-crank charger based on homopolar generator solves this problem. It works just as original hand-crank charger except it can charge tool batteries. I added the BATTERY_HEAVY flag to the clay car battery so it can be charged with this charger. I also added magnetite ore as a natural source of magnet for the charger.

Describe alternatives you've considered

I wish this charger could charge appliance and vehicle versions of batteries, but I'm not smart enough for that.

Testing

1.Mined magnetite.
2.Crafted a charger.
3.Reloaded it with clay car battery.
4.Charged battery.

Additional context

Added BATTERY_HEAVY flag to clay car battery
Added magnetite
Added magnetite spawn chance to solid rock
Changed steel to chunk of magnetite
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions Items: Battery / UPS Electric power management Spawn Creatures, items, vehicles, locations appearing on map Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Innawood 🌲 Anything to do with Innawood mod labels Dec 30, 2024
@Entott Entott changed the title [innawood] Add Makeshift hand-crank charger and magnetite ore [innawood] Add makeshift hand-crank charger and magnetite ore Dec 30, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Light-Wave

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 30, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A large chunk of magnetite, a ferrimagnetic oxide of iron. It can be magnetized to become a permanent magnet itself.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Entott and others added 3 commits December 30, 2024 03:58
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 30, 2024
@moxian
Copy link
Contributor

moxian commented Dec 30, 2024

You can't charge any battery without having a charged soldering iron

Please explain this part. I haven't tried setting up electricity in innawood, but this particular blocker seems odd. How exactly are you charging the battery, and why do you need to solder it?

Most of the crude electronic contraptions can be made by simply twisting the wires together, with no permanent solder. The solder is only there for fine work (like microcontroller terminals) and perhaps some amount of durability. None of this should be neccessary for making a battery?

What I'm trying to say that, while the hand-crank charger might be a fine addition to a mod in vacuum, it does not seem like the best solution to for the stated problem.

@Entott
Copy link
Contributor Author

Entott commented Dec 30, 2024

Please explain this part. I haven't tried setting up electricity in innawood, but this particular blocker seems odd. How exactly are you charging the battery, and why do you need to solder it?

Most of the crude electronic contraptions can be made by simply twisting the wires together, with no permanent solder. The solder is only there for fine work (like microcontroller terminals) and perhaps some amount of durability. None of this should be neccessary for making a battery?

What I'm trying to say that, while the hand-crank charger might be a fine addition to a mod in vacuum, it does not seem like the best solution to for the stated problem.

AFAIK there are 3 ways to charge a battery in the mod with electronics skill 4:
1.wind turbine
2.water wheel
3.bicycle alternator and motorbike alternator

As you see all of them require soldering. Maybe it's wrong and you can make crude or even good versions of all the above without soldering IRL too, but i decided to begin with making crude hand-crank charger.

@Light-Wave
Copy link
Contributor

Sounds reasonable. There used to be craftable solid batteries that were used to get battery power early in Innawood, but they seem to have been removed. This should kinda sorta fix that.
Another suggestion has been to make a primitive soldering iron that is a rod of iron you heat in a campfire. But this is fine too.
Something else to consider is that players may end up with a lot extra magnetite and not enough iron, so a recipe to turn magnetite to iron could be useful, but is not required for this PR.

@Entott
Copy link
Contributor Author

Entott commented Dec 30, 2024

Sounds reasonable. There used to be craftable solid batteries that were used to get battery power early in Innawood, but they seem to have been removed. This should kinda sorta fix that. Another suggestion has been to make a primitive soldering iron that is a rod of iron you heat in a campfire. But this is fine too. Something else to consider is that players may end up with a lot extra magnetite and not enough iron, so a recipe to turn magnetite to iron could be useful, but is not required for this PR.

Yes, I thought about it.
I originally added steel to the recipe thinking you'd turn it into a magnet by using it as a lightning rod beforehand. But some people on Discord didn't like that.

@moxian
Copy link
Contributor

moxian commented Dec 30, 2024

Oh, I see what you mean.
I think the bigger problem is that all of them require not only soldering iron, but also the handwavy "electronic scrap", which is unobtainable in innawood AFAIK (which hand-crank charger could also use in place of magnetite tbh).

Anyway, I now see the issue. The issue is not the way that we can't charge the battery, the problem is that we need to charge it in the first place. Which is wrong, because lead-acid batteries should come pre-charged (and non-rechargable).
But, yes, as I have just found out, the crafted lead-acid battery comes with zero charges. This is the bug that needs to be fixed, and not worked around.

Set "flags": ["FULL_MAGAZINE"], on the clay car battery recipe to make the battery spawn fully charged.

p.s.: @Light-Wave

There used to be craftable solid batteries that were used to get battery power early in Innawood, but they seem to have been removed. This should kinda sorta fix that.

They still exist, at least in some capacity -

[
{
"result": "battery_car_clay",
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"category": "CC_ELECTRONIC",
"subcategory": "CSC_ELECTRONIC_PARTS",
"skill_used": "electronics",
"difficulty": 2,
"skills_required": [ [ "fabrication", 2 ], [ "chemistry", 3 ] ],
"time": "30 m",
"autolearn": true,
"using": [ [ "surface_heat", 10, "LIST" ], [ "glazing", 2 ], [ "earthenware_firing", 120 ] ],
"proficiencies": [ { "proficiency": "prof_plasticworking" } ],
"qualities": [ { "id": "SCREW", "level": 1 } ],
"components": [
[ [ "scrap", 4 ] ],
[ [ "lead", 3200 ] ],
[ [ "chem_sulphuric_acid", 13 ] ],
[ [ "water", 2 ], [ "water_clean", 2 ] ],
[ [ "clay_lump", 5 ] ]
]
},

@Entott
Copy link
Contributor Author

Entott commented Dec 30, 2024

Anyway, I now see the issue. The issue is not the way that we can't charge the battery, the problem is that we need to charge it in the first place. Which is wrong, because lead-acid batteries should come pre-charged (and non-rechargable). But, yes, as I have just found out, the crafted lead-acid battery comes with zero charges. This is the bug that needs to be fixed, and not worked around.

Set "flags": ["FULL_MAGAZINE"], on the clay car battery recipe to make the battery spawn fully charged.

Will this battery be fully charged if you make it IRL? If so, I didn't know that.

Added chunk of magnetite to steel smelting recipes
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 30, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 30, 2024
@moxian
Copy link
Contributor

moxian commented Dec 31, 2024

Will this battery be fully charged if you make it IRL?

Yes, it will. See this wiki page for an example: https://en.wikipedia.org/wiki/Voltaic_pile
Or the lead-acid battery that the recipe aims to immitate, although wiki is a bit less explicit about the initial charge of that one: https://en.wikipedia.org/wiki/Lead%E2%80%93acid_battery

Also, potentially related: https://en.wikipedia.org/wiki/Lemon_battery (I initially assumed we have these ones innawood, but then realized that MA does not really grow lemons at all, and potatoes are a strong "maybe", so perhaps adding those to the game is a bit pointless)

@Maleclypse
Copy link
Member

Maleclypse commented Dec 31, 2024

and potatoes are a strong "maybe", so perhaps adding those to the game is a bit pointless)

Massachusetts grows more potatoes than any other New England state. So you can probably move that from maybe to yes.

Edit: unless your saying something I’m missing about potato batteries

@moxian
Copy link
Contributor

moxian commented Jan 1, 2025

No, you're not missing anything, I'm just being ignorant in the matters of agriculture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Battery / UPS Electric power management [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants