-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[innawood] Add makeshift hand-crank charger and magnetite ore #78844
base: master
Are you sure you want to change the base?
Conversation
Added BATTERY_HEAVY flag to clay car battery
Added magnetite
Added magnetite spawn chance to solid rock
Added magnetite
Changed steel to chunk of magnetite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @Light-Wave
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Please explain this part. I haven't tried setting up electricity in innawood, but this particular blocker seems odd. How exactly are you charging the battery, and why do you need to solder it? Most of the crude electronic contraptions can be made by simply twisting the wires together, with no permanent solder. The solder is only there for fine work (like microcontroller terminals) and perhaps some amount of durability. None of this should be neccessary for making a battery? What I'm trying to say that, while the hand-crank charger might be a fine addition to a mod in vacuum, it does not seem like the best solution to for the stated problem. |
AFAIK there are 3 ways to charge a battery in the mod with electronics skill 4: As you see all of them require soldering. Maybe it's wrong and you can make crude or even good versions of all the above without soldering IRL too, but i decided to begin with making crude hand-crank charger. |
Sounds reasonable. There used to be craftable solid batteries that were used to get battery power early in Innawood, but they seem to have been removed. This should kinda sorta fix that. |
Yes, I thought about it. |
Oh, I see what you mean. Anyway, I now see the issue. The issue is not the way that we can't charge the battery, the problem is that we need to charge it in the first place. Which is wrong, because lead-acid batteries should come pre-charged (and non-rechargable). Set p.s.: @Light-Wave
They still exist, at least in some capacity - Cataclysm-DDA/data/mods/innawood/recipes/electronic_parts.json Lines 1 to 23 in 7f812e6
|
Will this battery be fully charged if you make it IRL? If so, I didn't know that. |
Added chunk of magnetite to steel smelting recipes
Yes, it will. See this wiki page for an example: https://en.wikipedia.org/wiki/Voltaic_pile Also, potentially related: https://en.wikipedia.org/wiki/Lemon_battery (I initially assumed we have these ones innawood, but then realized that MA does not really grow lemons at all, and potatoes are a strong "maybe", so perhaps adding those to the game is a bit pointless) |
Massachusetts grows more potatoes than any other New England state. So you can probably move that from maybe to yes. Edit: unless your saying something I’m missing about potato batteries |
No, you're not missing anything, I'm just being ignorant in the matters of agriculture. |
Summary
Mods "[innawood] Add Makeshift hand-crank charger and magnetite ore."
Purpose of change
Right now it is impossible to reach an electricity era in this mod. You can't charge any battery without having a charged soldering iron. Also clay car battery is the only battery you can craft without electronics 5 skill, which is unreachable without charged soldering iron.
Describe the solution
A makeshift hand-crank charger based on homopolar generator solves this problem. It works just as original hand-crank charger except it can charge tool batteries. I added the BATTERY_HEAVY flag to the clay car battery so it can be charged with this charger. I also added magnetite ore as a natural source of magnet for the charger.
Describe alternatives you've considered
I wish this charger could charge appliance and vehicle versions of batteries, but I'm not smart enough for that.
Testing
1.Mined magnetite.
2.Crafted a charger.
3.Reloaded it with clay car battery.
4.Charged battery.
Additional context