Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Spells cost 1/5 of their normal cost on spell failure #78665

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[Magiclysm] Spells cost 1/5 of their normal cost on spell failure"

Purpose of change

It's always struck me as a little weird that you lose nothing but time for failing a spell. Presumably you're still trying to cast it, you just mess it up, so you still need to call up the mana and some of it would go to waste.

Also, I talked it over with KorGgenT and he agreed.

Describe the solution

Add an EoC that, when you cast a Magiclysm spell (including from attunements) and fail, you lose 1/5 of the normal mana cost.

Describe alternatives you've considered

Testing

Reduced mana is deducted when you fail. The cost of succeeding does not increase.

Hit up those spellbooks, kids.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod EOC: Effects On Condition Anything concerning Effects On Condition labels Dec 19, 2024
@github-actions github-actions bot requested a review from KorGgenT December 19, 2024 22:33
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 19, 2024
@cainiaowu
Copy link
Contributor

maybe adding some fluff text to player so that we know something happened instead of wondering why the additional mana cost

@cainiaowu
Copy link
Contributor

Thinking about it, the wasted mana need to go to somewhere, so the next step could be turning into something like wild magic surge table, adding more "fun" to the player.

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Dec 20, 2024

maybe adding some fluff text to player so that we know something happened instead of wondering why the additional mana cost

This would end up playing every single time you failed a cast, when it already says "You lose your concentration!" I think it'll be less disruptive overall once people get used to the idea that "You lose your concentration!" also means you lose mana.

Thinking about it, the wasted mana need to go to somewhere, so the next step could be turning into something like wild magic surge table, adding more "fun" to the player.

I already basically did this in Mind Over Matter, so I don't want to replicate it for Magiclysm. I'm also not sure if it fits the tone of the mod.

@keampe
Copy link
Contributor

keampe commented Dec 20, 2024

maybe adding some fluff text to player so that we know something happened instead of wondering why the additional mana cost

This would end up playing every single time you failed a cast, when it already says "You lose your concentration!" I think it'll be less disruptive overall once people get used to the idea that "You lose your concentration!" also means you lose mana.

Maybe a "special effect" like a tile of lightning on the caster and/or a fissle sound effect - no damage, just a graphical and/or auditory cue.

Might be out of scope for this PR, though. Probably unnecessary, too, for anyone who plays with Magiclysm more than occasionally.

  • Shane

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 20, 2024
@GuardianDll
Copy link
Member

If you want to add classless spells here, they are treated like they are tied by mutation of NONE

@Standing-Storm
Copy link
Contributor Author

I thought "Oh, I'll have to do another PR to fix the bug where if you fail to Stop Concentration in MoM while also running Magiclysm, you'll lose mana" but Stop Concentration has NO_FAIL so it shouldn't be a problem.

@GuardianDll
Copy link
Member

XE spells would be affected also, but they should be gone anyway, and ideally XE dream spells should both get the same treatment and an entirely different way to level them altogether (i wish someone but me make this change, but eh)

@Maleclypse Maleclypse merged commit a8338d6 into CleverRaven:master Dec 20, 2024
22 of 26 checks passed
@ashGlaw
Copy link
Contributor

ashGlaw commented Dec 21, 2024

XE spells would be affected also, but they should be gone anyway, and ideally XE dream spells should both get the same treatment and an entirely different way to level them altogether (i wish someone but me make this change, but eh)

Curious what you have in mind

@Standing-Storm Standing-Storm deleted the spells-cost-mana-on-failure branch December 21, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants