make underground inner walls same as outer #78232
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#77822 made some shelter walls parametrized, but not all. #78230 fixes the surface level of them.
The underground level currently has concrete outer walls and parametrized (different from surface) inner walls. This PR seeks to make them the same
I made this a different PR since I can see an argument to be made for making all basement walls parametrized (same as above ground) or make them all concrete. My preference is all concrete, because underground being eg. wooden doesn't fit imo.
Describe the solution
replace inner walls of all shelter_under mapgen with concrete walls (same as outer walls)
Describe alternatives you've considered
Make the outer walls parametrized
Testing
spawn in some shelters and go underground
Additional context
before:
after:
parametrized underground, imo inferior solution: