Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make underground inner walls same as outer #78232

Closed
wants to merge 2 commits into from

Conversation

marilynias
Copy link
Contributor

@marilynias marilynias commented Nov 29, 2024

Summary

None

Purpose of change

#77822 made some shelter walls parametrized, but not all. #78230 fixes the surface level of them.
The underground level currently has concrete outer walls and parametrized (different from surface) inner walls. This PR seeks to make them the same
I made this a different PR since I can see an argument to be made for making all basement walls parametrized (same as above ground) or make them all concrete. My preference is all concrete, because underground being eg. wooden doesn't fit imo.

Describe the solution

replace inner walls of all shelter_under mapgen with concrete walls (same as outer walls)

Describe alternatives you've considered

Make the outer walls parametrized

Testing

spawn in some shelters and go underground

Additional context

before:
Hong Amato _2024-11-29T14-55-01

after:
Hong Amato _2024-11-29T14-57-06

parametrized underground, imo inferior solution:
Hong Amato _2024-11-29T15-02-28

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 29, 2024
@marilynias marilynias changed the title [CR] make underground inner walls same as outer make underground inner walls same as outer Nov 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 29, 2024
@Maleclypse
Copy link
Member

Basements interior walls in New England are made of the parametrized materials. This shelter level is built like a basement not like a dungeon.

@Maleclypse Maleclypse closed this Nov 29, 2024
@marilynias marilynias deleted the f branch November 30, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants