Choose New Leader option on basecamp crashes the game

[gettingusedto]

Describe the bug

Basically what the title said. It crashed when i want to choose Liam as a new leader.

Attach save file

Wood-trimmed.tar.gz

Steps to reproduce

1. Open attached save.
2. interact the camp bulletin board nearby
3. select Choose New Leader
4. crash

Expected behavior

It not crashing and letting me play as Liam for awhile

Screenshots

No response

Versions and configuration

• OS: Android
  • OS Version: Manufacturer: ZTE; Model: ZTE 8050; Release: 13; Incremental: 20240523.205226;
• Game Version: cdda-experimental-2024-11-18-1457 c544d81 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth],
  GUT's Contents Compendium [gut_contents_compendium],
  GUT's Unhinged Stuff [gut_unhinged_stuff],
  Xedra Evolved [xedra_evolved],
  GUT's Tweak Compendium [gut_tweaks_compendium],
  GUT's Xedra Evolved Compendium [gut_xedra_compendium],
  Bombastic Perks [bombastic_perks],
  Martial Mastery [perk_melee_system],
  horde tweaks [horde_tweaks],
  Funni Loading Screens [loading_screen_funni]
  ]

Additional context

crash.log
debug.log

[Milopetilo]

/confirm
Didn't try this out in game but all tests except basic build seem to be failing because of this

[andrei8l]

/confirm Didn't try this out in game but all tests except basic build seem to be failing because of this

The LTO job is failing for an unrelated reason - see #77950. You should definitely verify before confirming.

I couldn't reproduce it from master. Based on the crash log and the timestamps, I'm quite certain this was an artifact of bad variable migration (#77980) combined with unsafe variable access here:

Cataclysm-DDA/src/faction_camp.cpp

Lines 1603 to 1607 in 3a0d074

	time_point last_succession_time = time_point::from_turn( std::stof(
	get_player_character().get_value( var_timer_time_of_last_succession ) ) );
	time_duration succession_cooldown = time_duration::from_turns( std::stof(
	get_globals().get_global_value(
	var_time_between_succession ) ) );

[gettingusedto]

Yeah after i updated my game, it stops crashing when i tried it. Sorry for the inconvenience.